| Message ID | 20240905-add_opt3002-v1-3-a5ae21b924fb@axis.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: light: opt3001: add support for TI's opt3002 light sensor | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 05/09/2024 12:20, Emil Gedenryd wrote: > OPT3002 is a Light-to-Digital Sensor by TI with support for wide-range > spectrum light. > Add the compatible string of opt3002 to the existing list. > > Signed-off-by: Emil Gedenryd <emil.gedenryd@axis.com> > --- > Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml b/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml > index 441e9343fc97..7a48a06968ca 100644 > --- a/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml > +++ b/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml > @@ -16,6 +16,7 @@ description: | > properties: > compatible: > const: ti,opt3001 > + const: ti,opt3002 Never tested and obviously broken. It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof
On Thu, 05 Sep 2024 12:20:47 +0200, Emil Gedenryd wrote: > OPT3002 is a Light-to-Digital Sensor by TI with support for wide-range > spectrum light. > Add the compatible string of opt3002 to the existing list. > > Signed-off-by: Emil Gedenryd <emil.gedenryd@axis.com> > --- > Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml:19:5: [error] duplication of key "const" in mapping (key-duplicates) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml: ignoring, error parsing file ./Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml:19:5: found duplicate key "const" with value "ti,opt3002" (original value: "ti,opt3001") make[2]: *** Deleting file 'Documentation/devicetree/bindings/iio/light/ti,opt3001.example.dts' Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml:19:5: found duplicate key "const" with value "ti,opt3002" (original value: "ti,opt3001") make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/iio/light/ti,opt3001.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1432: dt_binding_check] Error 2 make: *** [Makefile:224: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240905-add_opt3002-v1-3-a5ae21b924fb@axis.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml b/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml index 441e9343fc97..7a48a06968ca 100644 --- a/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml +++ b/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml @@ -16,6 +16,7 @@ description: | properties: compatible: const: ti,opt3001 + const: ti,opt3002 reg: maxItems: 1
OPT3002 is a Light-to-Digital Sensor by TI with support for wide-range spectrum light. Add the compatible string of opt3002 to the existing list. Signed-off-by: Emil Gedenryd <emil.gedenryd@axis.com> --- Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml | 1 + 1 file changed, 1 insertion(+)