| Message ID | 20240828030511.443605-2-quic_jingyw@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | remoteproc: qcom: Introduce DSP support for QCS8300 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, Aug 28, 2024 at 11:05:10AM +0800, Jingyi Wang wrote: > Document the components used to boot the ADSP, CDSP and GPDSP on the > QCS8300 SoC. > > Co-developed-by: Xin Liu <quic_liuxin@quicinc.com> > Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> > Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> > --- > .../bindings/remoteproc/qcom,sa8775p-pas.yaml | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml > index 7fe401a06805..44b070a17ca0 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml > @@ -16,6 +16,9 @@ description: > properties: > compatible: > enum: > + - qcom,qcs8300-adsp-pas > + - qcom,qcs8300-cdsp-pas > + - qcom,qcs8300-gpdsp-pas > - qcom,sa8775p-adsp-pas > - qcom,sa8775p-cdsp0-pas > - qcom,sa8775p-cdsp1-pas > @@ -64,6 +67,7 @@ allOf: > properties: > compatible: > enum: > + - qcom,qcs8300-adsp-pas > - qcom,sa8775p-adsp-pas > then: > properties: > @@ -75,6 +79,23 @@ allOf: > items: > - const: lcx > - const: lmx > + - if: > + properties: > + compatible: > + enum: > + - qcom,qcs8300-cdsp-pas This looks the same as sa8775p cdsp. Why new entry? Best regards, Krzysztof
On 8/28/2024 3:22 PM, Krzysztof Kozlowski wrote: > On Wed, Aug 28, 2024 at 11:05:10AM +0800, Jingyi Wang wrote: >> Document the components used to boot the ADSP, CDSP and GPDSP on the >> QCS8300 SoC. >> >> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com> >> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> >> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> >> --- >> .../bindings/remoteproc/qcom,sa8775p-pas.yaml | 22 +++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml >> index 7fe401a06805..44b070a17ca0 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml >> @@ -16,6 +16,9 @@ description: >> properties: >> compatible: >> enum: >> + - qcom,qcs8300-adsp-pas >> + - qcom,qcs8300-cdsp-pas >> + - qcom,qcs8300-gpdsp-pas >> - qcom,sa8775p-adsp-pas >> - qcom,sa8775p-cdsp0-pas >> - qcom,sa8775p-cdsp1-pas >> @@ -64,6 +67,7 @@ allOf: >> properties: >> compatible: >> enum: >> + - qcom,qcs8300-adsp-pas >> - qcom,sa8775p-adsp-pas >> then: >> properties: >> @@ -75,6 +79,23 @@ allOf: >> items: >> - const: lcx >> - const: lmx >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,qcs8300-cdsp-pas > > This looks the same as sa8775p cdsp. Why new entry? > There is difference in power domain, sa8775p use nsp while qcs8300 use nsp0 > Best regards, > Krzysztof > Thanks, Jingyi
On 28/08/2024 09:28, Jingyi Wang wrote: > > > On 8/28/2024 3:22 PM, Krzysztof Kozlowski wrote: >> On Wed, Aug 28, 2024 at 11:05:10AM +0800, Jingyi Wang wrote: >>> Document the components used to boot the ADSP, CDSP and GPDSP on the >>> QCS8300 SoC. >>> >>> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com> >>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> >>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> >>> --- >>> .../bindings/remoteproc/qcom,sa8775p-pas.yaml | 22 +++++++++++++++++++ >>> 1 file changed, 22 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml >>> index 7fe401a06805..44b070a17ca0 100644 >>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml >>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml >>> @@ -16,6 +16,9 @@ description: >>> properties: >>> compatible: >>> enum: >>> + - qcom,qcs8300-adsp-pas >>> + - qcom,qcs8300-cdsp-pas >>> + - qcom,qcs8300-gpdsp-pas >>> - qcom,sa8775p-adsp-pas >>> - qcom,sa8775p-cdsp0-pas >>> - qcom,sa8775p-cdsp1-pas >>> @@ -64,6 +67,7 @@ allOf: >>> properties: >>> compatible: >>> enum: >>> + - qcom,qcs8300-adsp-pas >>> - qcom,sa8775p-adsp-pas >>> then: >>> properties: >>> @@ -75,6 +79,23 @@ allOf: >>> items: >>> - const: lcx >>> - const: lmx >>> + - if: >>> + properties: >>> + compatible: >>> + enum: >>> + - qcom,qcs8300-cdsp-pas >> >> This looks the same as sa8775p cdsp. Why new entry? >> > There is difference in power domain, sa8775p use nsp while qcs8300 use nsp0 Please paste code where do you see the difference. Best regards, Krzysztof
On 8/28/2024 5:07 PM, Krzysztof Kozlowski wrote: > On 28/08/2024 09:28, Jingyi Wang wrote: >> >> >> On 8/28/2024 3:22 PM, Krzysztof Kozlowski wrote: >>> On Wed, Aug 28, 2024 at 11:05:10AM +0800, Jingyi Wang wrote: >>>> Document the components used to boot the ADSP, CDSP and GPDSP on the >>>> QCS8300 SoC. >>>> >>>> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com> >>>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> >>>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> >>>> --- >>>> .../bindings/remoteproc/qcom,sa8775p-pas.yaml | 22 +++++++++++++++++++ >>>> 1 file changed, 22 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml >>>> index 7fe401a06805..44b070a17ca0 100644 >>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml >>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml >>>> @@ -16,6 +16,9 @@ description: >>>> properties: >>>> compatible: >>>> enum: >>>> + - qcom,qcs8300-adsp-pas >>>> + - qcom,qcs8300-cdsp-pas >>>> + - qcom,qcs8300-gpdsp-pas >>>> - qcom,sa8775p-adsp-pas >>>> - qcom,sa8775p-cdsp0-pas >>>> - qcom,sa8775p-cdsp1-pas >>>> @@ -64,6 +67,7 @@ allOf: >>>> properties: >>>> compatible: >>>> enum: >>>> + - qcom,qcs8300-adsp-pas >>>> - qcom,sa8775p-adsp-pas >>>> then: >>>> properties: >>>> @@ -75,6 +79,23 @@ allOf: >>>> items: >>>> - const: lcx >>>> - const: lmx >>>> + - if: >>>> + properties: >>>> + compatible: >>>> + enum: >>>> + - qcom,qcs8300-cdsp-pas >>> >>> This looks the same as sa8775p cdsp. Why new entry? >>> >> There is difference in power domain, sa8775p use nsp while qcs8300 use nsp0 > > Please paste code where do you see the difference. > > Best regards, > Krzysztof > sorry my mistake, I have checked that nsp0 is form the view of power domain, it should be fine to use "nsp" to find the right power domain, will cleanup both binding and driver patch. Thanks, Jingyi
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml index 7fe401a06805..44b070a17ca0 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml @@ -16,6 +16,9 @@ description: properties: compatible: enum: + - qcom,qcs8300-adsp-pas + - qcom,qcs8300-cdsp-pas + - qcom,qcs8300-gpdsp-pas - qcom,sa8775p-adsp-pas - qcom,sa8775p-cdsp0-pas - qcom,sa8775p-cdsp1-pas @@ -64,6 +67,7 @@ allOf: properties: compatible: enum: + - qcom,qcs8300-adsp-pas - qcom,sa8775p-adsp-pas then: properties: @@ -75,6 +79,23 @@ allOf: items: - const: lcx - const: lmx + - if: + properties: + compatible: + enum: + - qcom,qcs8300-cdsp-pas + then: + properties: + power-domains: + items: + - description: CX power domain + - description: MXC power domain + - description: NSP0 power domain + power-domain-names: + items: + - const: cx + - const: mxc + - const: nsp0 - if: properties: @@ -99,6 +120,7 @@ allOf: properties: compatible: enum: + - qcom,qcs8300-gpdsp-pas - qcom,sa8775p-gpdsp0-pas - qcom,sa8775p-gpdsp1-pas then: