| Message ID | 20240822105238.213019-2-ilordash02@gmail.com |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | dt-bindings: phy: ti,tcan104x-can: Document Microchip | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 22-08-24, 13:52, Ilya Orazov wrote: > Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode. > It is pin-compatible with TI TCAN1042 and has a compatible programming > model, therefore use ti,tcan1042 as fallback compatible. > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Ilya Orazov <ilordash02@gmail.com> > --- > .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > index 79dad3e89aa6..4a8c3829d85d 100644 > --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > @@ -14,10 +14,15 @@ properties: > pattern: "^can-phy" > > compatible: > - enum: > - - nxp,tjr1443 > - - ti,tcan1042 > - - ti,tcan1043 > + oneOf: > + - items: > + - enum: > + - microchip,ata6561 > + - const: ti,tcan1042 > + - enum: > + - ti,tcan1042 > + - ti,tcan1043 > + - nxp,tjr1443 No driver/dt for new compatibles? > > '#phy-cells': > const: 0 > -- > 2.34.1
On Thu, 29 Aug 2024 at 21:13, Vinod Koul <vkoul@kernel.org> wrote: > > On 22-08-24, 13:52, Ilya Orazov wrote: > > Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode. > > It is pin-compatible with TI TCAN1042 and has a compatible programming > > model, therefore use ti,tcan1042 as fallback compatible. > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Signed-off-by: Ilya Orazov <ilordash02@gmail.com> > > --- > > .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++---- > > 1 file changed, 9 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > > index 79dad3e89aa6..4a8c3829d85d 100644 > > --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > > +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > > @@ -14,10 +14,15 @@ properties: > > pattern: "^can-phy" > > > > compatible: > > - enum: > > - - nxp,tjr1443 > > - - ti,tcan1042 > > - - ti,tcan1043 > > + oneOf: > > + - items: > > + - enum: > > + - microchip,ata6561 > > + - const: ti,tcan1042 > > + - enum: > > + - ti,tcan1042 > > + - ti,tcan1043 > > + - nxp,tjr1443 > > No driver/dt for new compatibles? There is phy-can-transceiver.c driver that can be used also for ata6561. I used this PHY in my own DTS. It is a popular chip, so I decided to add ATA6561 to the kernel, as I believe it would be beneficial. > > > > > '#phy-cells': > > const: 0 > > -- > > 2.34.1 > > -- > ~Vinod -- Best regards, Ilya Orazov
diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml index 79dad3e89aa6..4a8c3829d85d 100644 --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml @@ -14,10 +14,15 @@ properties: pattern: "^can-phy" compatible: - enum: - - nxp,tjr1443 - - ti,tcan1042 - - ti,tcan1043 + oneOf: + - items: + - enum: + - microchip,ata6561 + - const: ti,tcan1042 + - enum: + - ti,tcan1042 + - ti,tcan1043 + - nxp,tjr1443 '#phy-cells': const: 0