| Message ID | 20240821105943.230281-4-ada@thorsis.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | Microchip OTPC driver on SAM9X60 exposing UIDxR as additional nvmem device | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Wed, 21 Aug 2024 12:59:34 +0200, Alexander Dahl wrote: > The SAM9X60 SoC family has a similar OTPC to the SAMA7G5 family. > > Signed-off-by: Alexander Dahl <ada@thorsis.com> > --- > .../devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.example.dtb: efuse@e8c00000: compatible:0: 'microchip,sam9x60-otpc' was expected from schema $id: http://devicetree.org/schemas/nvmem/microchip,sama7g5-otpc.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.example.dtb: efuse@e8c00000: compatible:1: 'microchip,sama7g5-otpc' was expected from schema $id: http://devicetree.org/schemas/nvmem/microchip,sama7g5-otpc.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.example.dtb: efuse@e8c00000: compatible: ['microchip,sama7g5-otpc', 'syscon'] is too short from schema $id: http://devicetree.org/schemas/nvmem/microchip,sama7g5-otpc.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.example.dtb: efuse@e8c00000: Unevaluated properties are not allowed ('compatible' was unexpected) from schema $id: http://devicetree.org/schemas/nvmem/microchip,sama7g5-otpc.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240821105943.230281-4-ada@thorsis.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Wed, Aug 21, 2024 at 12:59:34PM +0200, Alexander Dahl wrote: > The SAM9X60 SoC family has a similar OTPC to the SAMA7G5 family. > > Signed-off-by: Alexander Dahl <ada@thorsis.com> > --- > .../devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml b/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml > index cc25f2927682..d98b6711bdfd 100644 > --- a/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml > +++ b/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml > @@ -21,6 +21,7 @@ allOf: > properties: > compatible: > items: > + - const: microchip,sam9x60-otpc > - const: microchip,sama7g5-otpc > - const: syscon As Rob's bot pointed out, this breaks the existing devicetrees. If you want a fallback to the sama7g5, then you will need to add a new items list here, alongside the existing one. Cheers, Conor. > > -- > 2.39.2 >
diff --git a/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml b/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml index cc25f2927682..d98b6711bdfd 100644 --- a/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml +++ b/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml @@ -21,6 +21,7 @@ allOf: properties: compatible: items: + - const: microchip,sam9x60-otpc - const: microchip,sama7g5-otpc - const: syscon
The SAM9X60 SoC family has a similar OTPC to the SAMA7G5 family. Signed-off-by: Alexander Dahl <ada@thorsis.com> --- .../devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml | 1 + 1 file changed, 1 insertion(+)