| Message ID | 20240811153507.126512-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | dt-bindings: fsl: fsl,rcpm: fix unevaluated fsl,rcpm-wakeup property | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 9 lines checked |
| robh/patch-applied | fail | build log |
On Sun, Aug 11, 2024 at 05:35:07PM +0200, Krzysztof Kozlowski wrote: > Drop the RCPM consumer example from the binding (LPUART device node), > because: > 1. Using phandles is typical syntax, thus explaining it is not needed in > the provider binding, > 2. It has 'fsl,rcpm-wakeup' property which is not allowed by LPUART > binding so it causes dt_binding_check warning: > > fsl,rcpm.example.dtb: serial@2950000: Unevaluated properties are not allowed ('fsl,rcpm-wakeup' was unexpected) > from schema $id: http://devicetree.org/schemas/serial/fsl-lpuart.yaml# > > Alternatively, this property could be added to LPUART binding > (fsl-lpuart.yaml), but it looks like none of in-tree DTS use it. > > Fixes: ad21e3840a88 ("dt-bindings: soc: fsl: Convert rcpm to yaml format") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Frank Li <Frank.Li@nxp.com> > --- > .../devicetree/bindings/soc/fsl/fsl,rcpm.yaml | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/fsl/fsl,rcpm.yaml b/Documentation/devicetree/bindings/soc/fsl/fsl,rcpm.yaml > index a7db0aad2b25..03d71ab930d7 100644 > --- a/Documentation/devicetree/bindings/soc/fsl/fsl,rcpm.yaml > +++ b/Documentation/devicetree/bindings/soc/fsl/fsl,rcpm.yaml > @@ -80,17 +80,8 @@ additionalProperties: false > examples: > - | > #include <dt-bindings/interrupt-controller/arm-gic.h> > - rcpm: global-utilities@e2000 { > + global-utilities@e2000 { > compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0"; > reg = <0xe2000 0x1000>; > #fsl,rcpm-wakeup-cells = <2>; > }; > - > - serial@2950000 { > - compatible = "fsl,ls1021a-lpuart"; > - reg = <0x2950000 0x1000>; > - interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&sysclk>; > - clock-names = "ipg"; > - fsl,rcpm-wakeup = <&rcpm 0x0 0x40000000>; > - }; > -- > 2.43.0 >
On Sun, Aug 11, 2024 at 05:35:07PM +0200, Krzysztof Kozlowski wrote: > Drop the RCPM consumer example from the binding (LPUART device node), > because: > 1. Using phandles is typical syntax, thus explaining it is not needed in > the provider binding, > 2. It has 'fsl,rcpm-wakeup' property which is not allowed by LPUART > binding so it causes dt_binding_check warning: > > fsl,rcpm.example.dtb: serial@2950000: Unevaluated properties are not allowed ('fsl,rcpm-wakeup' was unexpected) > from schema $id: http://devicetree.org/schemas/serial/fsl-lpuart.yaml# > > Alternatively, this property could be added to LPUART binding > (fsl-lpuart.yaml), but it looks like none of in-tree DTS use it. > > Fixes: ad21e3840a88 ("dt-bindings: soc: fsl: Convert rcpm to yaml format") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Sun, 11 Aug 2024 17:35:07 +0200, Krzysztof Kozlowski wrote: > Drop the RCPM consumer example from the binding (LPUART device node), > because: > 1. Using phandles is typical syntax, thus explaining it is not needed in > the provider binding, > 2. It has 'fsl,rcpm-wakeup' property which is not allowed by LPUART > binding so it causes dt_binding_check warning: > > fsl,rcpm.example.dtb: serial@2950000: Unevaluated properties are not allowed ('fsl,rcpm-wakeup' was unexpected) > from schema $id: http://devicetree.org/schemas/serial/fsl-lpuart.yaml# > > Alternatively, this property could be added to LPUART binding > (fsl-lpuart.yaml), but it looks like none of in-tree DTS use it. > > Fixes: ad21e3840a88 ("dt-bindings: soc: fsl: Convert rcpm to yaml format") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/soc/fsl/fsl,rcpm.yaml | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/soc/fsl/fsl,rcpm.yaml b/Documentation/devicetree/bindings/soc/fsl/fsl,rcpm.yaml index a7db0aad2b25..03d71ab930d7 100644 --- a/Documentation/devicetree/bindings/soc/fsl/fsl,rcpm.yaml +++ b/Documentation/devicetree/bindings/soc/fsl/fsl,rcpm.yaml @@ -80,17 +80,8 @@ additionalProperties: false examples: - | #include <dt-bindings/interrupt-controller/arm-gic.h> - rcpm: global-utilities@e2000 { + global-utilities@e2000 { compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0"; reg = <0xe2000 0x1000>; #fsl,rcpm-wakeup-cells = <2>; }; - - serial@2950000 { - compatible = "fsl,ls1021a-lpuart"; - reg = <0x2950000 0x1000>; - interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&sysclk>; - clock-names = "ipg"; - fsl,rcpm-wakeup = <&rcpm 0x0 0x40000000>; - };
Drop the RCPM consumer example from the binding (LPUART device node), because: 1. Using phandles is typical syntax, thus explaining it is not needed in the provider binding, 2. It has 'fsl,rcpm-wakeup' property which is not allowed by LPUART binding so it causes dt_binding_check warning: fsl,rcpm.example.dtb: serial@2950000: Unevaluated properties are not allowed ('fsl,rcpm-wakeup' was unexpected) from schema $id: http://devicetree.org/schemas/serial/fsl-lpuart.yaml# Alternatively, this property could be added to LPUART binding (fsl-lpuart.yaml), but it looks like none of in-tree DTS use it. Fixes: ad21e3840a88 ("dt-bindings: soc: fsl: Convert rcpm to yaml format") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/soc/fsl/fsl,rcpm.yaml | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)