| Message ID | 20240808191735.1483572-1-ilordash02@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v3,1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Thu, Aug 08, 2024 at 10:17:35PM +0300, Ilya Orazov wrote: > Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode. > It is pin-compatible with TI TCAN1042 and has a compatible programming > model, therefore use ti,tcan1042 as fallback compatible. > > Signed-off-by: Ilya Orazov <ilordash02@gmail.com> > --- Acked-by: Conor Dooley <conor.dooley@microchip.com> btw, please don't send new versions as a reply to existing ones, it's a shortcut to getting lost in deep mailboxes that sort by thread (or as I almost did here, deletion of the mail without reading it).
On Thu, 8 Aug 2024 at 22:18, Ilya Orazov <ilordash02@gmail.com> wrote: > > Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode. > It is pin-compatible with TI TCAN1042 and has a compatible programming > model, therefore use ti,tcan1042 as fallback compatible. > > Signed-off-by: Ilya Orazov <ilordash02@gmail.com> > --- > .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > index 79dad3e89aa6..4a8c3829d85d 100644 > --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > @@ -14,10 +14,15 @@ properties: > pattern: "^can-phy" > > compatible: > - enum: > - - nxp,tjr1443 > - - ti,tcan1042 > - - ti,tcan1043 > + oneOf: > + - items: > + - enum: > + - microchip,ata6561 > + - const: ti,tcan1042 > + - enum: > + - ti,tcan1042 > + - ti,tcan1043 > + - nxp,tjr1443 > > '#phy-cells': > const: 0 > > base-commit: 6a0e38264012809afa24113ee2162dc07f4ed22b > -- > 2.34.1 > Could you please review my patch? I hope the new patch version hasn't been lost in your inbox. Thanks to Conor, I understand now that sending new versions as a reply wasn't the best approach. I appreciate your time and feedback.
On 13/08/2024 19:14, Ilya Orazov wrote: >> '#phy-cells': >> const: 0 >> >> base-commit: 6a0e38264012809afa24113ee2162dc07f4ed22b >> -- >> 2.34.1 >> > > Could you please review my patch? You received review. Why do you ping after few days? Best regards, Krzysztof
On Wed, 14 Aug 2024 at 12:03, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 13/08/2024 19:14, Ilya Orazov wrote: > >> '#phy-cells': > >> const: 0 > >> > >> base-commit: 6a0e38264012809afa24113ee2162dc07f4ed22b > >> -- > >> 2.34.1 > >> > > > > Could you please review my patch? > > You received review. Why do you ping after few days? I have uploaded new patch version and fixed all dt-binding errors, so I thought you might want to review this updated version.
diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml index 79dad3e89aa6..4a8c3829d85d 100644 --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml @@ -14,10 +14,15 @@ properties: pattern: "^can-phy" compatible: - enum: - - nxp,tjr1443 - - ti,tcan1042 - - ti,tcan1043 + oneOf: + - items: + - enum: + - microchip,ata6561 + - const: ti,tcan1042 + - enum: + - ti,tcan1042 + - ti,tcan1043 + - nxp,tjr1443 '#phy-cells': const: 0
Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode. It is pin-compatible with TI TCAN1042 and has a compatible programming model, therefore use ti,tcan1042 as fallback compatible. Signed-off-by: Ilya Orazov <ilordash02@gmail.com> --- .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) base-commit: 6a0e38264012809afa24113ee2162dc07f4ed22b