| Message ID | 20240807180956.1341332-2-ilordash02@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2,1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Wed, 07 Aug 2024 21:09:56 +0300, Ilya Orazov wrote: > Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode. > It is pin-compatible with TI TCAN1042 and has a compatible programming > model, therefore use ti,tcan1042 as fallback compatible. > > Signed-off-by: Ilya Orazov <ilordash02@gmail.com> > --- > .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation) ./Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml:20:11: [warning] wrong indentation: expected 12 but found 10 (indentation) ./Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml:24:11: [error] duplication of key "const" in mapping (key-duplicates) ./Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml:25:11: [error] duplication of key "const" in mapping (key-duplicates) dtschema/dtc warnings/errors: make[2]: *** Deleting file 'Documentation/devicetree/bindings/phy/ti,tcan104x-can.example.dts' Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml:24:11: found duplicate key "const" with value "ti,tcan1043" (original value: "ti,tcan1042") make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/phy/ti,tcan104x-can.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml:24:11: found duplicate key "const" with value "ti,tcan1043" (original value: "ti,tcan1042") /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml: ignoring, error parsing file make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 make: *** [Makefile:240: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240807180956.1341332-2-ilordash02@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Wed, Aug 07, 2024 at 09:09:56PM +0300, Ilya Orazov wrote: > Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode. > It is pin-compatible with TI TCAN1042 and has a compatible programming > model, therefore use ti,tcan1042 as fallback compatible. > > Signed-off-by: Ilya Orazov <ilordash02@gmail.com> > --- > .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > index 79dad3e89aa6..f6f1fd843874 100644 > --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > @@ -14,10 +14,15 @@ properties: > pattern: "^can-phy" > > compatible: > - enum: > - - nxp,tjr1443 > - - ti,tcan1042 > - - ti,tcan1043 > + oneOf: > + - items: > + - enum: > + - microchip,ata6561 > + - const: ti,tcan1042 > + - enum: > + const: ti,tcan1042 > + const: ti,tcan1043 > + const: nxp,tjr1443 The enum doesn't need the "const:s", just a "-", hence the bot complaining.
On 08/08/2024 17:48, Conor Dooley wrote: > On Wed, Aug 07, 2024 at 09:09:56PM +0300, Ilya Orazov wrote: >> Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode. >> It is pin-compatible with TI TCAN1042 and has a compatible programming >> model, therefore use ti,tcan1042 as fallback compatible. >> >> Signed-off-by: Ilya Orazov <ilordash02@gmail.com> >> --- >> .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++---- >> 1 file changed, 9 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml >> index 79dad3e89aa6..f6f1fd843874 100644 >> --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml >> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml >> @@ -14,10 +14,15 @@ properties: >> pattern: "^can-phy" >> >> compatible: >> - enum: >> - - nxp,tjr1443 >> - - ti,tcan1042 >> - - ti,tcan1043 >> + oneOf: >> + - items: >> + - enum: >> + - microchip,ata6561 >> + - const: ti,tcan1042 >> + - enum: >> + const: ti,tcan1042 >> + const: ti,tcan1043 >> + const: nxp,tjr1443 > > The enum doesn't need the "const:s", just a "-", hence the bot > complaining. Plus indentation is broken, which is important for YAML. Before posting the patch, please test it. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml index 79dad3e89aa6..f6f1fd843874 100644 --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml @@ -14,10 +14,15 @@ properties: pattern: "^can-phy" compatible: - enum: - - nxp,tjr1443 - - ti,tcan1042 - - ti,tcan1043 + oneOf: + - items: + - enum: + - microchip,ata6561 + - const: ti,tcan1042 + - enum: + const: ti,tcan1042 + const: ti,tcan1043 + const: nxp,tjr1443 '#phy-cells': const: 0
Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode. It is pin-compatible with TI TCAN1042 and has a compatible programming model, therefore use ti,tcan1042 as fallback compatible. Signed-off-by: Ilya Orazov <ilordash02@gmail.com> --- .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)