diff mbox series

dt-bindings: clock: nxp,lpc3220-clk: Convert bindings to DT schema

Message ID 20240729193731.142069-1-animeshagarwal28@gmail.com
State Changes Requested
Headers show
Series dt-bindings: clock: nxp,lpc3220-clk: Convert bindings to DT schema | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 2 warnings, 51 lines checked
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Animesh Agarwal July 29, 2024, 7:37 p.m. UTC 
Convert the NXP LPC32xx Clock Controller bindings to yaml format.

Cc: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
---
 .../bindings/clock/nxp,lpc3220-clk.txt        | 30 -----------
 .../bindings/clock/nxp,lpc3220-clk.yaml       | 51 +++++++++++++++++++
 2 files changed, 51 insertions(+), 30 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt
 create mode 100644 Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.yaml

Comments

Krzysztof Kozlowski July 30, 2024, 3:57 p.m. UTC | #1 
On 29/07/2024 21:37, Animesh Agarwal wrote:
> Convert the NXP LPC32xx Clock Controller bindings to yaml format.
> 
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>

> +
> +properties:
> +  compatible:
> +    const: nxp,lpc3220-clk
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#clock-cells':
> +    const: 1
> +
> +  clocks:
> +    description: Phandles of external oscillators, the list must contain one
> +      32768 Hz oscillator and may have one optional high frequency oscillator.
> +    maxItems: 2

That's not correct and does not match clock-names. List the items with
description instead of above "phandles ...." and add minItems.


> +
> +  clock-names:
> +    oneOf:

Drop. It's:

minItems: 1
items:
 - const: ...
 - const:

> +      - items:
> +          - const: xtal_32k
> +          - const: xtal
> +      - const: xtal_32k
> +


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt
deleted file mode 100644
index 20cbca3f41d8..000000000000
--- a/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt
+++ /dev/null
@@ -1,30 +0,0 @@ 
-NXP LPC32xx Clock Controller
-
-Required properties:
-- compatible: should be "nxp,lpc3220-clk"
-- reg:  should contain clock controller registers location and length
-- #clock-cells: must be 1, the cell holds id of a clock provided by the
-  clock controller
-- clocks: phandles of external oscillators, the list must contain one
-  32768 Hz oscillator and may have one optional high frequency oscillator
-- clock-names: list of external oscillator clock names, must contain
-  "xtal_32k" and may have optional "xtal"
-
-Examples:
-
-	/* System Control Block */
-	scb {
-		compatible = "simple-bus";
-		ranges = <0x0 0x040004000 0x00001000>;
-		#address-cells = <1>;
-		#size-cells = <1>;
-
-		clk: clock-controller@0 {
-			compatible = "nxp,lpc3220-clk";
-			reg = <0x00 0x114>;
-			#clock-cells = <1>;
-
-			clocks = <&xtal_32k>, <&xtal>;
-			clock-names = "xtal_32k", "xtal";
-		};
-	};
diff --git a/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.yaml b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.yaml
new file mode 100644
index 000000000000..2faa845bab21
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.yaml
@@ -0,0 +1,51 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/nxp,lpc3220-clk.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP LPC32xx Clock Controller
+
+maintainers:
+  - Animesh Agarwal <animeshagarwal28@gmail.com>
+
+properties:
+  compatible:
+    const: nxp,lpc3220-clk
+
+  reg:
+    maxItems: 1
+
+  '#clock-cells':
+    const: 1
+
+  clocks:
+    description: Phandles of external oscillators, the list must contain one
+      32768 Hz oscillator and may have one optional high frequency oscillator.
+    maxItems: 2
+
+  clock-names:
+    oneOf:
+      - items:
+          - const: xtal_32k
+          - const: xtal
+      - const: xtal_32k
+
+required:
+  - compatible
+  - reg
+  - '#clock-cells'
+  - clocks
+  - clock-names
+
+additionalProperties: false
+
+examples:
+  - |
+    clock-controller@0 {
+        compatible = "nxp,lpc3220-clk";
+        reg = <0x00 0x114>;
+        #clock-cells = <1>;
+        clocks = <&xtal_32k>, <&xtal>;
+        clock-names = "xtal_32k", "xtal";
+    };