| Message ID | 20240725121609.13101-4-pierre-henry.moussay@microchip.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [01/17] dt-bindings: can: mpfs: add PIC64GX CAN compatibility | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Thu, Jul 25, 2024 at 01:15:55PM +0100, pierre-henry.moussay@microchip.com wrote: > From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com> > > PIC64GX mailbox is compatible with MPFS mailbox driver I don't want this one merged as-is. The mpfs binding here is wrong, and doesn't describe the hardware properly. One of the regions should be described as an mfd or syscon because there are several unrelated functions (hwmon, a reset, mailbox cr/sr and trimming) there - see pfsoc_control_scb in the regmap for more information. The mpfs binding should be fixed, rather than adding something incorrect here for the pic64gx. I'm on holidays atm, I'll try to explain more when I get back. > > Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com> > --- > .../devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml > index 404477910f02..9e45112e185a 100644 > --- a/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml > +++ b/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml > @@ -11,7 +11,11 @@ maintainers: > > properties: > compatible: > - const: microchip,mpfs-mailbox > + oneOf: > + - items: > + - const: microchip,pic64gx-mailbox > + - const: microchip,mpfs-mailbox > + - const: microchip,mpfs-mailbox > > reg: > oneOf: > -- > 2.30.2 > >
diff --git a/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml index 404477910f02..9e45112e185a 100644 --- a/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml +++ b/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml @@ -11,7 +11,11 @@ maintainers: properties: compatible: - const: microchip,mpfs-mailbox + oneOf: + - items: + - const: microchip,pic64gx-mailbox + - const: microchip,mpfs-mailbox + - const: microchip,mpfs-mailbox reg: oneOf: