| Message ID | 20240725121609.13101-15-pierre-henry.moussay@microchip.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [01/17] dt-bindings: can: mpfs: add PIC64GX CAN compatibility | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Thu, Jul 25, 2024 at 01:16:06PM +0100, pierre-henry.moussay@microchip.com wrote: > From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com> > > PIC64GX is compatible with mpfs-sys-controller driver without additional > feature Bindings are about hardware, not drivers. Are you sure a fallback is appropriate here? Does the system controller expose the same features as it does on PolarFire SoC? For example, FPGA reprogramming: the driver creates a platform device to which the auto update driver is bound - I don't think that that is appropriate on a pic64gx. Thanks, Conor. > > Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com> > --- > .../soc/microchip/microchip,mpfs-sys-controller.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml > index a3fa04f3a1bd..af89d5959747 100644 > --- a/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml > +++ b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml > @@ -24,7 +24,11 @@ properties: > maxItems: 1 > > compatible: > - const: microchip,mpfs-sys-controller > + oneOf: > + - items: > + - const: microchip,pic64gx-sys-controller > + - const: microchip,mpfs-sys-controller > + - const: microchip,mpfs-sys-controller > > microchip,bitstream-flash: > $ref: /schemas/types.yaml#/definitions/phandle > -- > 2.30.2 > >
diff --git a/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml index a3fa04f3a1bd..af89d5959747 100644 --- a/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml +++ b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml @@ -24,7 +24,11 @@ properties: maxItems: 1 compatible: - const: microchip,mpfs-sys-controller + oneOf: + - items: + - const: microchip,pic64gx-sys-controller + - const: microchip,mpfs-sys-controller + - const: microchip,mpfs-sys-controller microchip,bitstream-flash: $ref: /schemas/types.yaml#/definitions/phandle