| Message ID | 20240725104528.3504967-3-quic_varada@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add interconnect driver for IPQ5332 SoC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 25/07/2024 12:45, Varadarajan Narayanan wrote: > USB uses icc-clk framework to enable the NoC interface clock. > Hence the 'iface' clock is removed from the list of clocks. > Update the clock-names list accordingly. > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- Explanation you gave in v4 should be in the commit msg. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, Jul 29, 2024 at 05:13:04PM +0200, Krzysztof Kozlowski wrote: > On 25/07/2024 12:45, Varadarajan Narayanan wrote: > > USB uses icc-clk framework to enable the NoC interface clock. > > Hence the 'iface' clock is removed from the list of clocks. > > Update the clock-names list accordingly. > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > Explanation you gave in v4 should be in the commit msg. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Have posted V6 with the updated commit msg. Thanka Varada
diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml index efde47a5b145..aef42dacc202 100644 --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml @@ -164,6 +164,7 @@ allOf: contains: enum: - qcom,ipq4019-dwc3 + - qcom,ipq5332-dwc3 then: properties: clocks: @@ -267,7 +268,6 @@ allOf: contains: enum: - qcom,ipq5018-dwc3 - - qcom,ipq5332-dwc3 - qcom,msm8994-dwc3 - qcom,qcs404-dwc3 then:
USB uses icc-clk framework to enable the NoC interface clock. Hence the 'iface' clock is removed from the list of clocks. Update the clock-names list accordingly. Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> --- v5: Use ipq4019-dwc3 clock details for ipq5332 instead of new one --- Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)