| Message ID | 20240723110733.10988-4-oliver.rhodes.aj@renesas.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Document r8a774a3 SoC bindings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, Jul 23, 2024 at 12:07:30PM +0100, Oliver Rhodes wrote: > Add binding documentation for Renesas RZ/G2M v3.0 (a.k.a r8a774a3) Clock > Pulse Generator driver. > > Signed-off-by: Oliver Rhodes <oliver.rhodes.aj@renesas.com> > --- > v1->v1 resend: > * No change. > --- > Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml > index 084259d30232..77ce3615c65a 100644 > --- a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml > +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml > @@ -31,6 +31,7 @@ properties: > - renesas,r8a7745-cpg-mssr # RZ/G1E > - renesas,r8a77470-cpg-mssr # RZ/G1C > - renesas,r8a774a1-cpg-mssr # RZ/G2M > + - renesas,r8a774a3-cpg-mssr # RZ/G2M v3.0 Please explain in your commit message why a fallback is not suitable here. > - renesas,r8a774b1-cpg-mssr # RZ/G2N > - renesas,r8a774c0-cpg-mssr # RZ/G2E > - renesas,r8a774e1-cpg-mssr # RZ/G2H > -- > 2.34.1 > >
Hi Conor, Thank you for the feedback. > -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Tuesday, July 23, 2024 3:04 PM > Subject: Re: [PATCH V1 resend 3/6] dt-bindings: clock: renesas: Document RZ/G2M v3.0 (r8a774a3) clock > > On Tue, Jul 23, 2024 at 12:07:30PM +0100, Oliver Rhodes wrote: > > Add binding documentation for Renesas RZ/G2M v3.0 (a.k.a r8a774a3) > > Clock Pulse Generator driver. > > > > Signed-off-by: Oliver Rhodes <oliver.rhodes.aj@renesas.com> > > --- > > v1->v1 resend: > > * No change. > > --- > > Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml > > b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml > > index 084259d30232..77ce3615c65a 100644 > > --- a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml > > +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml > > @@ -31,6 +31,7 @@ properties: > > - renesas,r8a7745-cpg-mssr # RZ/G1E > > - renesas,r8a77470-cpg-mssr # RZ/G1C > > - renesas,r8a774a1-cpg-mssr # RZ/G2M > > + - renesas,r8a774a3-cpg-mssr # RZ/G2M v3.0 > > Please explain in your commit message why a fallback is not suitable here. The r8a774a1-cpg-mssr is almost identical to r8a774a3-cpg-mssr, but it lacks clocks like FCPCI. To handle this difference, we need to use a separate compatible. I will update the commit message in the next version. Thanks, Oliver
diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml index 084259d30232..77ce3615c65a 100644 --- a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml @@ -31,6 +31,7 @@ properties: - renesas,r8a7745-cpg-mssr # RZ/G1E - renesas,r8a77470-cpg-mssr # RZ/G1C - renesas,r8a774a1-cpg-mssr # RZ/G2M + - renesas,r8a774a3-cpg-mssr # RZ/G2M v3.0 - renesas,r8a774b1-cpg-mssr # RZ/G2N - renesas,r8a774c0-cpg-mssr # RZ/G2E - renesas,r8a774e1-cpg-mssr # RZ/G2H
Add binding documentation for Renesas RZ/G2M v3.0 (a.k.a r8a774a3) Clock Pulse Generator driver. Signed-off-by: Oliver Rhodes <oliver.rhodes.aj@renesas.com> --- v1->v1 resend: * No change. --- Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml | 1 + 1 file changed, 1 insertion(+)