| Message ID | 20240718102637.3964232-3-xu.yang_2@nxp.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Thu, Jul 18, 2024 at 06:26:34PM +0800, Xu Yang wrote: > i.MX7ULP need properly set System Integration Module(SIM) module to make > usb wakeup work well. This will add a "nxp,sim" property. > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > --- > .../devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > index f4b1ca2fb562..2141f271f8f1 100644 > --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > @@ -87,6 +87,12 @@ properties: > maximum: 119 > default: 100 > > + nxp,sim: > + description: > + The system integration module (SIM) provides system control and chip > + configuration registers. > + $ref: /schemas/types.yaml#/definitions/phandle > + > required: > - compatible > - reg > @@ -110,6 +116,14 @@ allOf: > required: > - fsl,anatop > > + - if: > + properties: > + compatible: > + const: fsl,imx7ulp-usbphy > + then: > + required: > + - nxp,sim else: properties: nxp,sim: false > + > additionalProperties: false > > examples: > -- > 2.34.1 >
On Mon, Jul 22, 2024 at 08:51:10PM -0600, Rob Herring wrote: > On Thu, Jul 18, 2024 at 06:26:34PM +0800, Xu Yang wrote: > > i.MX7ULP need properly set System Integration Module(SIM) module to make > > usb wakeup work well. This will add a "nxp,sim" property. > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- > > .../devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > index f4b1ca2fb562..2141f271f8f1 100644 > > --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > @@ -87,6 +87,12 @@ properties: > > maximum: 119 > > default: 100 > > > > + nxp,sim: > > + description: > > + The system integration module (SIM) provides system control and chip > > + configuration registers. > > + $ref: /schemas/types.yaml#/definitions/phandle > > + > > required: > > - compatible > > - reg > > @@ -110,6 +116,14 @@ allOf: > > required: > > - fsl,anatop > > > > + - if: > > + properties: > > + compatible: > > + const: fsl,imx7ulp-usbphy > > + then: > > + required: > > + - nxp,sim > > else: > properties: > nxp,sim: false Okay, I will add it. Thanks, Xu Yang > > > > + > > additionalProperties: false > > > > examples: > > -- > > 2.34.1 > >
diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml index f4b1ca2fb562..2141f271f8f1 100644 --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml @@ -87,6 +87,12 @@ properties: maximum: 119 default: 100 + nxp,sim: + description: + The system integration module (SIM) provides system control and chip + configuration registers. + $ref: /schemas/types.yaml#/definitions/phandle + required: - compatible - reg @@ -110,6 +116,14 @@ allOf: required: - fsl,anatop + - if: + properties: + compatible: + const: fsl,imx7ulp-usbphy + then: + required: + - nxp,sim + additionalProperties: false examples:
i.MX7ULP need properly set System Integration Module(SIM) module to make usb wakeup work well. This will add a "nxp,sim" property. Signed-off-by: Xu Yang <xu.yang_2@nxp.com> --- .../devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+)