| Message ID | 20240612-boston-syscon-v2-8-9f8e1a07fa63@flygoat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | MIPS: Boston: Fix syscon devicetree binding and node | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, Jun 12, 2024 at 12:56:27PM +0100, Jiaxun Yang wrote: > Add devices binding for various Imagination Technologies > MIPS based Platforms. > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> > --- > .../devicetree/bindings/mips/img/devices.yaml | 33 ++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mips/img/devices.yaml b/Documentation/devicetree/bindings/mips/img/devices.yaml > new file mode 100644 > index 000000000000..460ca96577ad > --- /dev/null > +++ b/Documentation/devicetree/bindings/mips/img/devices.yaml > @@ -0,0 +1,33 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mips/img/devices.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Imagination Technologies MIPS based Platforms > + > +maintainers: > + - Jiaxun Yang <jiaxun.yang@flygoat.com> > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + > + - description: IMG Boston > + const: img,boston > + > + - description: IMG Marduk (Creator Ci40) > + items: > + - const: img,pistachio-marduk > + - const: img,pistachio > + > + - description: Imagination University Program MIPSfpga > + items: > + - const: img,xilfpga > + - const: digilent,nexys4ddr Usually the order used here is something like: compatible = "vendor,soc-board", "vendor,soc" The pistachio one seems to follow that, but AFAICT "boston" is a board and the order in this one is something like: compatible = "vendor,soc", "vendor,generic-fpga-board"
在2024年6月12日六月 下午5:43，Conor Dooley写道： [...] > Usually the order used here is something like: > compatible = "vendor,soc-board", "vendor,soc" > The pistachio one seems to follow that, but AFAICT "boston" is a board > and the order in this one is something like: > compatible = "vendor,soc", "vendor,generic-fpga-board" Boston is an FPGA & Emulation platform, so I don't have a good answer for what should I fill as SoC. Thanks > > 附件: > * signature.asc
On Wed, Jun 12, 2024 at 05:57:55PM +0100, Jiaxun Yang wrote: > > > 在2024年6月12日六月 下午5:43，Conor Dooley写道： > [...] > > Usually the order used here is something like: > > compatible = "vendor,soc-board", "vendor,soc" > > The pistachio one seems to follow that, but AFAICT "boston" is a board > > and the order in this one is something like: > > compatible = "vendor,soc", "vendor,generic-fpga-board" > > Boston is an FPGA & Emulation platform, so I don't have a good answer > for what should I fill as SoC. Ah right. Probably worth adding a little more information then as to what the platforms are in the commit message in that case.
On Wed, Jun 12, 2024 at 12:56:27PM +0100, Jiaxun Yang wrote: > Add devices binding for various Imagination Technologies > MIPS based Platforms. > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> > --- > .../devicetree/bindings/mips/img/devices.yaml | 33 ++++++++++++++++++++++ > 1 file changed, 33 insertions(+) Please drop the old bindings or at least the portion covered by this. That's Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt, pistachio.txt, and xilfpga.txt. Some of the description can go in here. CPU nodes are documented elsewhere by schemas already and can be dropped. The boot protocol isn't really DT bindings, so that belongs elsewhere if you want to keep it. Documentation/arch/mips/ perhaps? Rob
diff --git a/Documentation/devicetree/bindings/mips/img/devices.yaml b/Documentation/devicetree/bindings/mips/img/devices.yaml new file mode 100644 index 000000000000..460ca96577ad --- /dev/null +++ b/Documentation/devicetree/bindings/mips/img/devices.yaml @@ -0,0 +1,33 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mips/img/devices.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Imagination Technologies MIPS based Platforms + +maintainers: + - Jiaxun Yang <jiaxun.yang@flygoat.com> + +properties: + $nodename: + const: '/' + compatible: + oneOf: + + - description: IMG Boston + const: img,boston + + - description: IMG Marduk (Creator Ci40) + items: + - const: img,pistachio-marduk + - const: img,pistachio + + - description: Imagination University Program MIPSfpga + items: + - const: img,xilfpga + - const: digilent,nexys4ddr + +additionalProperties: true + +...
Add devices binding for various Imagination Technologies MIPS based Platforms. Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> --- .../devicetree/bindings/mips/img/devices.yaml | 33 ++++++++++++++++++++++ 1 file changed, 33 insertions(+)