| Message ID | 20240514220457.94571-1-marex@denx.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 28 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 5/15/24 06:04, Marek Vasut wrote: > The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property, > move the property description into the DW HDMI common DT schema too, so this > property can be used on all devices integrating the DW HDMI core. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Andrzej Hajda <andrzej.hajda@intel.com> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: David Airlie <airlied@gmail.com> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Jernej Skrabec <jernej.skrabec@gmail.com> > Cc: Jonas Karlman <jonas@kwiboo.se> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> > Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Neil Armstrong <neil.armstrong@linaro.org> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: Rob Herring <robh@kernel.org> > Cc: Robert Foss <rfoss@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: devicetree@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: imx@lists.linux.dev > Cc: kernel@dh-electronics.com > Cc: linux-arm-kernel@lists.infradead.org > --- > .../bindings/display/bridge/synopsys,dw-hdmi.yaml | 8 ++++++++ > .../devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml | 8 -------- > 2 files changed, 8 insertions(+), 8 deletions(-) Cc'ed Mark Yao. rockchip,dw-hdmi.yaml documents ddc-i2c-bus too. Drop it? Regards, Liu Ying > > diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > index 4b7e54a8f037f..828709a8ded26 100644 > --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > @@ -45,6 +45,14 @@ properties: > - const: isfr > additionalItems: true > > + ddc-i2c-bus: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + The HDMI DDC bus can be connected to either a system I2C master or the > + functionally-reduced I2C master contained in the DWC HDMI. When connected > + to a system I2C master this property contains a phandle to that I2C > + master controller. > + > interrupts: > maxItems: 1 > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > index 7979cf07f1199..180c4b510fb12 100644 > --- a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > @@ -31,14 +31,6 @@ properties: > clock-names: > maxItems: 2 > > - ddc-i2c-bus: > - $ref: /schemas/types.yaml#/definitions/phandle > - description: > - The HDMI DDC bus can be connected to either a system I2C master or the > - functionally-reduced I2C master contained in the DWC HDMI. When connected > - to a system I2C master this property contains a phandle to that I2C > - master controller. > - > gpr: > $ref: /schemas/types.yaml#/definitions/phandle > description:
On 5/15/24 5:12 AM, Liu Ying wrote: > On 5/15/24 06:04, Marek Vasut wrote: >> The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property, >> move the property description into the DW HDMI common DT schema too, so this >> property can be used on all devices integrating the DW HDMI core. >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> --- >> Cc: Andrzej Hajda <andrzej.hajda@intel.com> >> Cc: Conor Dooley <conor+dt@kernel.org> >> Cc: Daniel Vetter <daniel@ffwll.ch> >> Cc: David Airlie <airlied@gmail.com> >> Cc: Fabio Estevam <festevam@gmail.com> >> Cc: Jernej Skrabec <jernej.skrabec@gmail.com> >> Cc: Jonas Karlman <jonas@kwiboo.se> >> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> >> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> >> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> Cc: Maxime Ripard <mripard@kernel.org> >> Cc: Neil Armstrong <neil.armstrong@linaro.org> >> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> >> Cc: Philipp Zabel <p.zabel@pengutronix.de> >> Cc: Rob Herring <robh@kernel.org> >> Cc: Robert Foss <rfoss@kernel.org> >> Cc: Sascha Hauer <s.hauer@pengutronix.de> >> Cc: Shawn Guo <shawnguo@kernel.org> >> Cc: Thomas Zimmermann <tzimmermann@suse.de> >> Cc: devicetree@vger.kernel.org >> Cc: dri-devel@lists.freedesktop.org >> Cc: imx@lists.linux.dev >> Cc: kernel@dh-electronics.com >> Cc: linux-arm-kernel@lists.infradead.org >> --- >> .../bindings/display/bridge/synopsys,dw-hdmi.yaml | 8 ++++++++ >> .../devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml | 8 -------- >> 2 files changed, 8 insertions(+), 8 deletions(-) > > Cc'ed Mark Yao. > > rockchip,dw-hdmi.yaml documents ddc-i2c-bus too. Drop it? Fixed in V2 and uh , I forgot to CC Mark (sorry), so I'll wait with V3 for a few days now.
diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml index 4b7e54a8f037f..828709a8ded26 100644 --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml @@ -45,6 +45,14 @@ properties: - const: isfr additionalItems: true + ddc-i2c-bus: + $ref: /schemas/types.yaml#/definitions/phandle + description: + The HDMI DDC bus can be connected to either a system I2C master or the + functionally-reduced I2C master contained in the DWC HDMI. When connected + to a system I2C master this property contains a phandle to that I2C + master controller. + interrupts: maxItems: 1 diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml index 7979cf07f1199..180c4b510fb12 100644 --- a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml @@ -31,14 +31,6 @@ properties: clock-names: maxItems: 2 - ddc-i2c-bus: - $ref: /schemas/types.yaml#/definitions/phandle - description: - The HDMI DDC bus can be connected to either a system I2C master or the - functionally-reduced I2C master contained in the DWC HDMI. When connected - to a system I2C master this property contains a phandle to that I2C - master controller. - gpr: $ref: /schemas/types.yaml#/definitions/phandle description:
The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property, move the property description into the DW HDMI common DT schema too, so this property can be used on all devices integrating the DW HDMI core. Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Andrzej Hajda <andrzej.hajda@intel.com> Cc: Conor Dooley <conor+dt@kernel.org> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: David Airlie <airlied@gmail.com> Cc: Fabio Estevam <festevam@gmail.com> Cc: Jernej Skrabec <jernej.skrabec@gmail.com> Cc: Jonas Karlman <jonas@kwiboo.se> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Neil Armstrong <neil.armstrong@linaro.org> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Rob Herring <robh@kernel.org> Cc: Robert Foss <rfoss@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: devicetree@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: imx@lists.linux.dev Cc: kernel@dh-electronics.com Cc: linux-arm-kernel@lists.infradead.org --- .../bindings/display/bridge/synopsys,dw-hdmi.yaml | 8 ++++++++ .../devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml | 8 -------- 2 files changed, 8 insertions(+), 8 deletions(-)