| Message ID | 20240508170544.263059-2-chris.packham@alliedtelesis.co.nz |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hwmon: (adt7475) duty cycle configuration | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Thu, 09 May 2024 05:05:42 +1200, Chris Packham wrote: > Add documentation for the pwm-initial-duty-cycle and > pwm-initial-frequency properties. These allow the starting state of the > PWM outputs to be set to cater for hardware designs where undesirable > amounts of noise is created by the default hardware state. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > .../devicetree/bindings/hwmon/adt7475.yaml | 26 ++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/adt7475.example.dtb: hwmon@2e: adi,pwm-initial-frequency:0:1: 0 is not one of [11, 14, 22, 29, 35, 44, 58, 88, 22500] from schema $id: http://devicetree.org/schemas/hwmon/adt7475.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240508170544.263059-2-chris.packham@alliedtelesis.co.nz The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/hwmon/adt7475.yaml b/Documentation/devicetree/bindings/hwmon/adt7475.yaml index 051c976ab711..3de300c9da2a 100644 --- a/Documentation/devicetree/bindings/hwmon/adt7475.yaml +++ b/Documentation/devicetree/bindings/hwmon/adt7475.yaml @@ -51,6 +51,29 @@ properties: enum: [0, 1] default: 1 + adi,pwm-initial-duty-cycle: + description: | + Configures the initial duty cycle for the PWM outputs. The hardware + default is 100% but this may cause unwanted fan noise at startup. Set + this to a value from 0 (0% duty cycle) to 255 (100% duty cycle). + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 3 + maxItems: 3 + items: + minimum: 0 + maximum: 255 + default: 255 + + adi,pwm-initial-frequency: + description: | + Configures the initial frequency for the PWM outputs. + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 3 + maxItems: 3 + items: + enum: [11, 14, 22, 29, 35, 44, 58, 88, 22500] + default: 35 + patternProperties: "^adi,bypass-attenuator-in[0-4]$": description: | @@ -80,7 +103,6 @@ patternProperties: - therm# - smbalert# - gpio - required: - compatible - reg @@ -99,6 +121,8 @@ examples: adi,bypass-attenuator-in0 = <1>; adi,bypass-attenuator-in1 = <0>; adi,pwm-active-state = <1 0 1>; + adi,pwm-initial-duty-cycle = <128 0 128>; + adi,pwm-initial-frequency = <22500 0 22500>; adi,pin10-function = "smbalert#"; adi,pin14-function = "tach4"; };
Add documentation for the pwm-initial-duty-cycle and pwm-initial-frequency properties. These allow the starting state of the PWM outputs to be set to cater for hardware designs where undesirable amounts of noise is created by the default hardware state. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- .../devicetree/bindings/hwmon/adt7475.yaml | 26 ++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-)