Message ID | 20240503154402.967632-1-robh@kernel.org |
---|---|
State | Accepted |
Headers | show |
Series | dt-bindings: arm: sunxi: Fix incorrect '-' usage | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | warning | total: 0 errors, 2 warnings, 20 lines checked |
robh/patch-applied | fail | build log |
On 03/05/2024 17:44, Rob Herring (Arm) wrote: > Commit 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX > handheld gaming device variants") mistakenly added '-' on each line > which created empty (i.e. description only) schemas matching anything. > This causes validation to fail on all the root node compatibles as > there are multiple oneOf clauses passing. > > Fixes: 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX handheld gaming device variants") > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > Documentation/devicetree/bindings/arm/sunxi.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Sat, 4 May 2024, at 3:44 AM, Rob Herring (Arm) wrote: > Commit 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX > handheld gaming device variants") mistakenly added '-' on each line > which created empty (i.e. description only) schemas matching anything. > This causes validation to fail on all the root node compatibles as > there are multiple oneOf clauses passing. > > Fixes: 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX > handheld gaming device variants") > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- Apologies, thanks for the fix. Reviewed-by: Ryan Walklin <ryan@testtoast.com> Regards, Ryan
On Fri, 03 May 2024 10:44:02 -0500, Rob Herring (Arm) wrote: > Commit 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX > handheld gaming device variants") mistakenly added '-' on each line > which created empty (i.e. description only) schemas matching anything. > This causes validation to fail on all the root node compatibles as > there are multiple oneOf clauses passing. > > Fixes: 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX handheld gaming device variants") > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > Documentation/devicetree/bindings/arm/sunxi.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > No one has picked this up yet, so I have. Applied, thanks!
diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml index c6d0d8d81ed4..c2a158b75e49 100644 --- a/Documentation/devicetree/bindings/arm/sunxi.yaml +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml @@ -57,17 +57,17 @@ properties: - const: allwinner,sun8i-v3s - description: Anbernic RG35XX (2024) - - items: + items: - const: anbernic,rg35xx-2024 - const: allwinner,sun50i-h700 - description: Anbernic RG35XX Plus - - items: + items: - const: anbernic,rg35xx-plus - const: allwinner,sun50i-h700 - description: Anbernic RG35XX H - - items: + items: - const: anbernic,rg35xx-h - const: allwinner,sun50i-h700
Commit 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX handheld gaming device variants") mistakenly added '-' on each line which created empty (i.e. description only) schemas matching anything. This causes validation to fail on all the root node compatibles as there are multiple oneOf clauses passing. Fixes: 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX handheld gaming device variants") Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- Documentation/devicetree/bindings/arm/sunxi.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)