| Message ID | 20240503-midas-wm1811-gpio-jack-v1-1-e8cddbd67cbf@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ASoC: samsung: midas-audio: Add GPIO-based headset jack detection | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 03/05/2024 20:55, Artur Weber wrote: > Some Samsung devices that share the midas-audio driver use a GPIO-based > approach to headset jack detection, as opposed to using the built-in > jack detection provided by the wm8994 driver. > > Add DT configuration values that allow for describing these setups. > > Signed-off-by: Artur Weber <aweber.kernel@gmail.com> > --- > .../bindings/sound/samsung,midas-audio.yaml | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml b/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml > index 6ec80f529d84..9f521131f2b3 100644 > --- a/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml > +++ b/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml > @@ -61,6 +61,36 @@ properties: > maxItems: 1 > description: GPIO pin for line out selection > > + headset-detect-gpios: > + maxItems: 1 > + description: GPIO for detection of headset insertion > + > + headset-key-gpios: > + maxItems: 1 > + description: GPIO for detection of headset key press > + > + io-channels: > + maxItems: 1 > + description: IO channel to read micbias voltage for headset detection > + > + io-channel-names: > + const: headset-detect > + > + headset-4pole-threshold-microvolt: You need vendor prefix for this and next property. > + minItems: 2 > + maxItems: 2 > + description: | Do not need '|' unless you need to preserve formatting. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml b/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml index 6ec80f529d84..9f521131f2b3 100644 --- a/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml +++ b/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml @@ -61,6 +61,36 @@ properties: maxItems: 1 description: GPIO pin for line out selection + headset-detect-gpios: + maxItems: 1 + description: GPIO for detection of headset insertion + + headset-key-gpios: + maxItems: 1 + description: GPIO for detection of headset key press + + io-channels: + maxItems: 1 + description: IO channel to read micbias voltage for headset detection + + io-channel-names: + const: headset-detect + + headset-4pole-threshold-microvolt: + minItems: 2 + maxItems: 2 + description: | + Array containing minimum and maximum IO channel value for 4-pole + (with microphone/button) headsets. If the IO channel value is + outside of this range, a 3-pole headset is assumed. + + headset-button-threshold-microvolt: + minItems: 3 + maxItems: 3 + description: | + Array of minimum (inclusive) IO channel values for headset button + detection, in order: "Media", "Volume Up" and "Volume Down". + required: - compatible - cpu
Some Samsung devices that share the midas-audio driver use a GPIO-based approach to headset jack detection, as opposed to using the built-in jack detection provided by the wm8994 driver. Add DT configuration values that allow for describing these setups. Signed-off-by: Artur Weber <aweber.kernel@gmail.com> --- .../bindings/sound/samsung,midas-audio.yaml | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+)