| Message ID | 20240425213701.655540-6-eajames@linux.ibm.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | ARM: dts: aspeed: Add IBM P11 BMC Boards | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 25/04/2024 23:36, Eddie James wrote: > The SBEFIFO engine provides an interface to the POWER processor > Self Boot Engine (SBE). > > Signed-off-by: Eddie James <eajames@linux.ibm.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au> > --- > +description: > + The SBEFIFO is an FSI CFAM engine that provides an interface to the > + POWER processor Self Boot Engine (SBE). This node will always be a child > + of an FSI CFAM node; see fsi.txt for details on FSI slave and CFAM > + nodes. > + > +properties: > + compatible: > + enum: > + - ibm,p9-sbefifo > + - ibm,odyssey-sbefifo > + > + reg: > + items: > + - description: FSI slave address > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^occ(@.*)?": Why unit address is optional? Best regards, Krzysztof
On 4/26/24 01:20, Krzysztof Kozlowski wrote: > On 25/04/2024 23:36, Eddie James wrote: >> The SBEFIFO engine provides an interface to the POWER processor >> Self Boot Engine (SBE). >> >> Signed-off-by: Eddie James <eajames@linux.ibm.com> >> Acked-by: Conor Dooley <conor.dooley@microchip.com> >> Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au> >> --- > >> +description: >> + The SBEFIFO is an FSI CFAM engine that provides an interface to the >> + POWER processor Self Boot Engine (SBE). This node will always be a child >> + of an FSI CFAM node; see fsi.txt for details on FSI slave and CFAM >> + nodes. >> + >> +properties: >> + compatible: >> + enum: >> + - ibm,p9-sbefifo >> + - ibm,odyssey-sbefifo >> + >> + reg: >> + items: >> + - description: FSI slave address >> + >> + "#address-cells": >> + const: 1 >> + >> + "#size-cells": >> + const: 0 >> + >> +patternProperties: >> + "^occ(@.*)?": > Why unit address is optional? In this case, it's because we use the reg property (reflecting the unit address) to indicate the processor index of the occ node. However I think I should drop the unit address here, it's meaningless, there is no addressing for the OCC from the SBEFIFO. > > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.yaml b/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.yaml new file mode 100644 index 000000000000..72569147db2a --- /dev/null +++ b/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/fsi/ibm,p9-sbefifo.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: IBM FSI-attached SBEFIFO engine + +maintainers: + - Eddie James <eajames@linux.ibm.com> + +description: + The SBEFIFO is an FSI CFAM engine that provides an interface to the + POWER processor Self Boot Engine (SBE). This node will always be a child + of an FSI CFAM node; see fsi.txt for details on FSI slave and CFAM + nodes. + +properties: + compatible: + enum: + - ibm,p9-sbefifo + - ibm,odyssey-sbefifo + + reg: + items: + - description: FSI slave address + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^occ(@.*)?": + type: object + $ref: ibm,p9-occ.yaml# + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + fsi-slave-engine@2400 { + compatible = "ibm,p9-sbefifo"; + reg = <0x2400 0x400>; + };