| Message ID | 20240424190612.17349-2-afd@ti.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | TI K3 M4F support on AM62 SoCs | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Wed, 24 Apr 2024 14:06:09 -0500, Andrew Davis wrote: > From: Hari Nagalla <hnagalla@ti.com> > > K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain. > The remote processor's life cycle management and IPC mechanisms are > similar across the R5F and M4F cores from remote processor driver > point of view. However, there are subtle differences in image loading > and starting the M4F subsystems. > > The YAML binding document provides the various node properties to be > configured by the consumers of the M4F subsystem. > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > Signed-off-by: Andrew Davis <afd@ti.com> > --- > .../bindings/remoteproc/ti,k3-m4f-rproc.yaml | 126 ++++++++++++++++++ > 1 file changed, 126 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml references a file that doesn't exist: Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml: Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240424190612.17349-2-afd@ti.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Wed, Apr 24, 2024 at 03:36:39PM -0500, Rob Herring wrote: > > On Wed, 24 Apr 2024 14:06:09 -0500, Andrew Davis wrote: > > From: Hari Nagalla <hnagalla@ti.com> > > > > K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain. > > The remote processor's life cycle management and IPC mechanisms are > > similar across the R5F and M4F cores from remote processor driver > > point of view. However, there are subtle differences in image loading > > and starting the M4F subsystems. > > > > The YAML binding document provides the various node properties to be > > configured by the consumers of the M4F subsystem. > > > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > > Signed-off-by: Andrew Davis <afd@ti.com> > > --- > > .../bindings/remoteproc/ti,k3-m4f-rproc.yaml | 126 ++++++++++++++++++ > > 1 file changed, 126 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > > > doc reference errors (make refcheckdocs): > Warning: Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml references a file that doesn't exist: Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml > Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml: Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml The file is now in dt-schema: https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/reserved-memory/reserved-memory.yaml
On Wed, Apr 24, 2024 at 02:06:09PM -0500, Andrew Davis wrote: > From: Hari Nagalla <hnagalla@ti.com> > > K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain. > The remote processor's life cycle management and IPC mechanisms are > similar across the R5F and M4F cores from remote processor driver > point of view. However, there are subtle differences in image loading > and starting the M4F subsystems. > > The YAML binding document provides the various node properties to be > configured by the consumers of the M4F subsystem. > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > Signed-off-by: Andrew Davis <afd@ti.com> > + mboxes: > + description: | > + memory-region: > + description: | Not sure that either chomping operator is needed here, but that's a nit. With the incorrect link fixed up, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
On 4/25/24 12:15 PM, Conor Dooley wrote: > On Wed, Apr 24, 2024 at 03:36:39PM -0500, Rob Herring wrote: >> >> On Wed, 24 Apr 2024 14:06:09 -0500, Andrew Davis wrote: >>> From: Hari Nagalla <hnagalla@ti.com> >>> >>> K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain. >>> The remote processor's life cycle management and IPC mechanisms are >>> similar across the R5F and M4F cores from remote processor driver >>> point of view. However, there are subtle differences in image loading >>> and starting the M4F subsystems. >>> >>> The YAML binding document provides the various node properties to be >>> configured by the consumers of the M4F subsystem. >>> >>> Signed-off-by: Martyn Welch <martyn.welch@collabora.com> >>> Signed-off-by: Hari Nagalla <hnagalla@ti.com> >>> Signed-off-by: Andrew Davis <afd@ti.com> >>> --- >>> .../bindings/remoteproc/ti,k3-m4f-rproc.yaml | 126 ++++++++++++++++++ >>> 1 file changed, 126 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml >>> >> >> My bot found errors running 'make dt_binding_check' on your patch: >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> >> >> doc reference errors (make refcheckdocs): >> Warning: Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml references a file that doesn't exist: Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml >> Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml: Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml > > The file is now in dt-schema: > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/reserved-memory/reserved-memory.yaml So should I use "reserved-memory/reserved-memory.yaml" here, or just drop this line completely? Andrew
On Thu, Apr 25, 2024 at 02:03:36PM -0500, Andrew Davis wrote: > On 4/25/24 12:15 PM, Conor Dooley wrote: > > On Wed, Apr 24, 2024 at 03:36:39PM -0500, Rob Herring wrote: > > > > > > On Wed, 24 Apr 2024 14:06:09 -0500, Andrew Davis wrote: > > > > From: Hari Nagalla <hnagalla@ti.com> > > > > > > > > K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain. > > > > The remote processor's life cycle management and IPC mechanisms are > > > > similar across the R5F and M4F cores from remote processor driver > > > > point of view. However, there are subtle differences in image loading > > > > and starting the M4F subsystems. > > > > > > > > The YAML binding document provides the various node properties to be > > > > configured by the consumers of the M4F subsystem. > > > > > > > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > > > > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > > > > Signed-off-by: Andrew Davis <afd@ti.com> > > > > --- > > > > .../bindings/remoteproc/ti,k3-m4f-rproc.yaml | 126 ++++++++++++++++++ > > > > 1 file changed, 126 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > > > > > > > doc reference errors (make refcheckdocs): > > > Warning: Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml references a file that doesn't exist: Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml > > > Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml: Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml > > > > The file is now in dt-schema: > > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/reserved-memory/reserved-memory.yaml > > So should I use "reserved-memory/reserved-memory.yaml" here, or just > drop this line completely? The only other example that I could find that didn't reference the text binding (which points to dt-schema) said: "(see reserved-memory/reserved-memory.yaml in dtschema project)"
diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml new file mode 100644 index 0000000000000..3629ddd6efa8c --- /dev/null +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml @@ -0,0 +1,126 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/remoteproc/ti,k3-m4f-rproc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI K3 M4F processor subsystems + +maintainers: + - Hari Nagalla <hnagalla@ti.com> + - Mathieu Poirier <mathieu.poirier@linaro.org> + +description: | + Some K3 family SoCs have Arm Cortex M4F cores. AM64x is a SoC in K3 + family with a M4F core. Typically safety oriented applications may use + the M4F core in isolation without an IPC. Where as some industrial and + home automation applications, may use the M4F core as a remote processor + with IPC communications. + +$ref: /schemas/arm/keystone/ti,k3-sci-common.yaml# + +properties: + compatible: + enum: + - ti,am64-m4fss + + power-domains: + maxItems: 1 + + "#address-cells": + const: 2 + + "#size-cells": + const: 2 + + reg: + items: + - description: IRAM internal memory region + - description: DRAM internal memory region + + reg-names: + items: + - const: iram + - const: dram + + resets: + maxItems: 1 + + firmware-name: + maxItems: 1 + description: Name of firmware to load for the M4F core + + mboxes: + description: | + OMAP Mailbox specifier denoting the sub-mailbox, to be used for + communication with the remote processor. This property should match + with the sub-mailbox node used in the firmware image. + maxItems: 1 + + memory-region: + description: | + phandle to the reserved memory nodes to be associated with the + remoteproc device. The reserved memory nodes should be carveout nodes, + and should be defined with a "no-map" property as per the bindings in + Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml + Optional memory regions available for firmware specific purposes. + maxItems: 8 + items: + - description: regions used for DMA allocations like vrings, vring buffers + and memory dedicated to firmware's specific purposes. + additionalItems: true + +required: + - compatible + - reg + - reg-names + - ti,sci + - ti,sci-dev-id + - ti,sci-proc-ids + - resets + - firmware-name + +unevaluatedProperties: false + +examples: + - | + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + + mcu_m4fss_dma_memory_region: m4f-dma-memory@9cb00000 { + compatible = "shared-dma-pool"; + reg = <0x00 0x9cb00000 0x00 0x100000>; + no-map; + }; + + mcu_m4fss_memory_region: m4f-memory@9cc00000 { + compatible = "shared-dma-pool"; + reg = <0x00 0x9cc00000 0x00 0xe00000>; + no-map; + }; + }; + + soc { + #address-cells = <2>; + #size-cells = <2>; + + mailbox0_cluster0: mailbox-0 { + #mbox-cells = <1>; + }; + + remoteproc@5000000 { + compatible = "ti,am64-m4fss"; + reg = <0x00 0x5000000 0x00 0x30000>, + <0x00 0x5040000 0x00 0x10000>; + reg-names = "iram", "dram"; + ti,sci = <&dmsc>; + ti,sci-dev-id = <9>; + ti,sci-proc-ids = <0x18 0xff>; + resets = <&k3_reset 9 1>; + firmware-name = "am62-mcu-m4f0_0-fw"; + mboxes = <&mailbox0_cluster0>, <&mbox_m4_0>; + memory-region = <&mcu_m4fss_dma_memory_region>, + <&mcu_m4fss_memory_region>; + }; + };