| Message ID | 20240424-rockchip-pcie-ep-v1-v1-2-b1a02ddad650@kernel.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | PCI: dw-rockchip: Add endpoint mode support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, 24 Apr 2024 17:16:20 +0200, Niklas Cassel wrote: > Considering that some drivers (e.g. pcie-dw-rockchip.c) already use the > interrupt-names "sys", "pmc", "msg", "err" for the device tree binding in > Root Complex mode (snps,dw-pcie.yaml), it doesn't make sense that those > drivers should use different interrupt-names when running in Endpoint mode > (snps,dw-pcie-ep.yaml). > > Therefore, since "sys", "pmc", "msg", "err" are already defined in > snps,dw-pcie.yaml, add them also for snps,dw-pcie-ep.yaml. > > Signed-off-by: Niklas Cassel <cassel@kernel.org> > --- > Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml index 00dec01f1f73..f5f12cbc2cb3 100644 --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml @@ -156,7 +156,7 @@ properties: for new bindings. oneOf: - description: See native "app" IRQ for details - enum: [ intr ] + enum: [ intr, sys, pmc, msg, err ] max-functions: maximum: 32
Considering that some drivers (e.g. pcie-dw-rockchip.c) already use the interrupt-names "sys", "pmc", "msg", "err" for the device tree binding in Root Complex mode (snps,dw-pcie.yaml), it doesn't make sense that those drivers should use different interrupt-names when running in Endpoint mode (snps,dw-pcie-ep.yaml). Therefore, since "sys", "pmc", "msg", "err" are already defined in snps,dw-pcie.yaml, add them also for snps,dw-pcie-ep.yaml. Signed-off-by: Niklas Cassel <cassel@kernel.org> --- Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)