| Message ID | 20240420142108.76984-1-sheharyaar48@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: usb: uhci: convert to dt schema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 39 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 20/04/2024 16:21, Mohammad Shehar Yaar Tausif wrote: > Convert USB UHCI bindings to DT schema > > Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com> > --- Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/usb/usb-uhci.yaml b/Documentation/devicetree/bindings/usb/usb-uhci.yaml > new file mode 100644 > index 000000000000..511c3ecd8d53 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/usb-uhci.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/usb-uhci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic Platform UHCI Controller > + > +allOf: > + - $ref: usb-hcd.yaml# > + > +maintainers: > + - Greg Kroah-Hartman <gregkh@linuxfoundation.org> > + > +properties: > + compatible: > + const: generic-uhci You missed deprecated compatible. Also missed Aspeed compatibles. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts Please confirm that you tested DTS. > + > +unevaluatedProperties: false > + > +examples: > + - | > + usb@d8007b00 { > + compatible = "generic-uhci"; Use 4 spaces for example indentation. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/usb-uhci.txt b/Documentation/devicetree/bindings/usb/usb-uhci.txt deleted file mode 100644 index d1702eb2c8bd..000000000000 --- a/Documentation/devicetree/bindings/usb/usb-uhci.txt +++ /dev/null @@ -1,18 +0,0 @@ -Generic Platform UHCI Controller ------------------------------------------------------ - -Required properties: -- compatible : "generic-uhci" (deprecated: "platform-uhci") -- reg : Should contain 1 register ranges(address and length) -- interrupts : UHCI controller interrupt - -additionally the properties from usb-hcd.yaml (in the current directory) are -supported. - -Example: - - uhci@d8007b00 { - compatible = "generic-uhci"; - reg = <0xd8007b00 0x200>; - interrupts = <43>; - }; diff --git a/Documentation/devicetree/bindings/usb/usb-uhci.yaml b/Documentation/devicetree/bindings/usb/usb-uhci.yaml new file mode 100644 index 000000000000..511c3ecd8d53 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/usb-uhci.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/usb-uhci.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic Platform UHCI Controller + +allOf: + - $ref: usb-hcd.yaml# + +maintainers: + - Greg Kroah-Hartman <gregkh@linuxfoundation.org> + +properties: + compatible: + const: generic-uhci + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +unevaluatedProperties: false + +examples: + - | + usb@d8007b00 { + compatible = "generic-uhci"; + reg = <0xd8007b00 0x200>; + interrupts = <43>; + }; +...
Convert USB UHCI bindings to DT schema Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com> --- .../devicetree/bindings/usb/usb-uhci.txt | 18 --------- .../devicetree/bindings/usb/usb-uhci.yaml | 39 +++++++++++++++++++ 2 files changed, 39 insertions(+), 18 deletions(-) delete mode 100644 Documentation/devicetree/bindings/usb/usb-uhci.txt create mode 100644 Documentation/devicetree/bindings/usb/usb-uhci.yaml