| Message ID | 20240417-mcp251xfd-gpio-feature-v1-4-bc0c61fd0c80@ew.tq-group.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | can: mcp251xfd: add gpio functionality | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Wed, 17 Apr 2024 15:43:57 +0200, Gregor Herburger wrote: > The mcp251xfd has two pins that can be used as gpio. Add gpio-controller > property to binding description. > > Signed-off-by: Gregor Herburger <gregor.herburger@ew.tq-group.com> > --- > Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml | 2 ++ > 1 file changed, 2 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml: properties: '#gpio-cells' is a dependency of 'gpio-controller' from schema $id: http://devicetree.org/meta-schemas/gpios.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240417-mcp251xfd-gpio-feature-v1-4-bc0c61fd0c80@ew.tq-group.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 17/04/2024 15:43, Gregor Herburger wrote: > The mcp251xfd has two pins that can be used as gpio. Add gpio-controller > property to binding description. > Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. Also, please test the patch. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml b/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml index 2a98b26630cb..e8a3ad4b1231 100644 --- a/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml +++ b/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml @@ -49,6 +49,8 @@ properties: Must be half or less of "clocks" frequency. maximum: 20000000 + gpio-controller: true + required: - compatible - reg
The mcp251xfd has two pins that can be used as gpio. Add gpio-controller property to binding description. Signed-off-by: Gregor Herburger <gregor.herburger@ew.tq-group.com> --- Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml | 2 ++ 1 file changed, 2 insertions(+)