| Message ID | 20240415081305.316107-1-mike.looijmans@topic.nl |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/5] dt-bindings: power: Extend battery chemistry with capacitor | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 15/04/2024 10:13, Mike Looijmans wrote: > Another technology to store energy is a (super)capacitor. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > --- > > (no changes since v1) > > Documentation/devicetree/bindings/power/supply/battery.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml > index 491488e7b970..a22c97dfad88 100644 > --- a/Documentation/devicetree/bindings/power/supply/battery.yaml > +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml > @@ -44,6 +44,7 @@ properties: > - const: lithium-ion-polymer > - const: lithium-ion-iron-phosphate > - const: lithium-ion-manganese-oxide > + - const: capacitor Please keep some sort of order... everyone insists on adding to the end of the lists... Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 15-04-2024 17:24, Krzysztof Kozlowski wrote: > On 15/04/2024 10:13, Mike Looijmans wrote: >> Another technology to store energy is a (super)capacitor. >> >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >> --- >> >> (no changes since v1) >> >> Documentation/devicetree/bindings/power/supply/battery.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml >> index 491488e7b970..a22c97dfad88 100644 >> --- a/Documentation/devicetree/bindings/power/supply/battery.yaml >> +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml >> @@ -44,6 +44,7 @@ properties: >> - const: lithium-ion-polymer >> - const: lithium-ion-iron-phosphate >> - const: lithium-ion-manganese-oxide >> + - const: capacitor > Please keep some sort of order... everyone insists on adding to the end > of the lists... Could make it alphabetical, but that requires re-ordering the existing ones so "lithium" sorts before "nickel". I think the intention here was that the order is the same as the matching defines in power-supply.h > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof >
On 22/04/2024 09:50, Mike Looijmans wrote: > On 15-04-2024 17:24, Krzysztof Kozlowski wrote: >> On 15/04/2024 10:13, Mike Looijmans wrote: >>> Another technology to store energy is a (super)capacitor. >>> >>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >>> --- >>> >>> (no changes since v1) >>> >>> Documentation/devicetree/bindings/power/supply/battery.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml >>> index 491488e7b970..a22c97dfad88 100644 >>> --- a/Documentation/devicetree/bindings/power/supply/battery.yaml >>> +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml >>> @@ -44,6 +44,7 @@ properties: >>> - const: lithium-ion-polymer >>> - const: lithium-ion-iron-phosphate >>> - const: lithium-ion-manganese-oxide >>> + - const: capacitor >> Please keep some sort of order... everyone insists on adding to the end >> of the lists... > > Could make it alphabetical, but that requires re-ordering the existing > ones so "lithium" sorts before "nickel". So just put it at beginning, less sorting later. > > I think the intention here was that the order is the same as the > matching defines in power-supply.h There is no such binding as power-supply.h. And other headers do not matter, they are not bindings. Best regards, Krzysztof
On 22-04-2024 13:56, Krzysztof Kozlowski wrote: > On 22/04/2024 09:50, Mike Looijmans wrote: >> On 15-04-2024 17:24, Krzysztof Kozlowski wrote: >>> On 15/04/2024 10:13, Mike Looijmans wrote: >>>> Another technology to store energy is a (super)capacitor. >>>> >>>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >>>> --- >>>> >>>> (no changes since v1) >>>> >>>> Documentation/devicetree/bindings/power/supply/battery.yaml | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml >>>> index 491488e7b970..a22c97dfad88 100644 >>>> --- a/Documentation/devicetree/bindings/power/supply/battery.yaml >>>> +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml >>>> @@ -44,6 +44,7 @@ properties: >>>> - const: lithium-ion-polymer >>>> - const: lithium-ion-iron-phosphate >>>> - const: lithium-ion-manganese-oxide >>>> + - const: capacitor >>> Please keep some sort of order... everyone insists on adding to the end >>> of the lists... >> Could make it alphabetical, but that requires re-ordering the existing >> ones so "lithium" sorts before "nickel". > So just put it at beginning, less sorting later. Ok. I'll wait a bit for comments on the other parts, before sending a v6 of the series. > >> I think the intention here was that the order is the same as the >> matching defines in power-supply.h > There is no such binding as power-supply.h. And other headers do not > matter, they are not bindings. Clear, thanks.
diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml index 491488e7b970..a22c97dfad88 100644 --- a/Documentation/devicetree/bindings/power/supply/battery.yaml +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml @@ -44,6 +44,7 @@ properties: - const: lithium-ion-polymer - const: lithium-ion-iron-phosphate - const: lithium-ion-manganese-oxide + - const: capacitor over-voltage-threshold-microvolt: description: battery over-voltage limit
Another technology to store energy is a (super)capacitor. Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> --- (no changes since v1) Documentation/devicetree/bindings/power/supply/battery.yaml | 1 + 1 file changed, 1 insertion(+)