| Message ID | 20240408090506.21596-3-zajec5@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/3] dt-bindings: pinctrl: mediatek: mt7622: fix array properties | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Mon, Apr 08, 2024 at 11:05:06AM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > Both: MT7622 and MT7629 use two reg spaces: "base" and "eint". It wasn't > covered by the binding and also example didn't match incomplete binding. > Fix it. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > .../bindings/pinctrl/mediatek,mt7622-pinctrl.yaml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml > index a9ab623b2697..eaa65512161a 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml > @@ -19,10 +19,12 @@ properties: > - mediatek,mt7629-pinctrl > > reg: > - maxItems: 1 > + minItems: 2 > + maxItems: 2 This should become an items list with descriptions IMO. > reg-names: > items: > + - const: base > - const: eint Why isnt the new region appended to the list?
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml index a9ab623b2697..eaa65512161a 100644 --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml @@ -19,10 +19,12 @@ properties: - mediatek,mt7629-pinctrl reg: - maxItems: 1 + minItems: 2 + maxItems: 2 reg-names: items: + - const: base - const: eint gpio-controller: true @@ -364,7 +366,9 @@ examples: pio: pinctrl@10211000 { compatible = "mediatek,mt7622-pinctrl"; - reg = <0 0x10211000 0 0x1000>; + reg = <0 0x10211000 0 0x1000>, + <0 0x10005000 0 0x1000>; + reg-names = "base", "eint"; gpio-controller; #gpio-cells = <2>;