Message ID | 20240311222605.1940826-1-robh@kernel.org |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | media: dt-bindings: qcom,i2c-cci: Fix OV7251 'data-lanes' entries | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/patch-applied | success | |
robh/dtbs-check | warning | build log |
robh/dt-meta-schema | success |
On 11/03/2024 23:26, Rob Herring wrote: > The OV7251 sensor only has a single data lane, so 2 entries is not valid. > Fix this to be 1 entry as the schema specifies. > > The schema validation doesn't catch this currently due to some limitations > in handling of arrays vs. matrices, but a fix is being worked on. > > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml index 8386cfe21532..f0eabff86310 100644 --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml @@ -270,7 +270,7 @@ examples: port { ov7251_ep: endpoint { - data-lanes = <0 1>; + data-lanes = <0>; link-frequencies = /bits/ 64 <240000000 319200000>; remote-endpoint = <&csiphy3_ep>; };
The OV7251 sensor only has a single data lane, so 2 entries is not valid. Fix this to be 1 entry as the schema specifies. The schema validation doesn't catch this currently due to some limitations in handling of arrays vs. matrices, but a fix is being worked on. Signed-off-by: Rob Herring <robh@kernel.org> --- Of course, with only 1 lane, I'm not sure why we need data-lanes in the first place? --- Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)