| Message ID | 20240217-hisi-wdt-v1-2-cdb9ddcab968@outlook.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | watchdog: sp805: add reset control support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 17/02/2024 05:40, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@outlook.com> > > The reset signal needs to be deasserted before operation of sp805 > module. Document in the binding. > Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. It's dt-bindings > Signed-off-by: Yang Xiwen <forbidden405@outlook.com> > --- > Documentation/devicetree/bindings/watchdog/arm,sp805.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml > index 7aea255b301b..6d4f63f23f1a 100644 > --- a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml > +++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml > @@ -50,6 +50,11 @@ properties: > - const: wdog_clk > - const: apb_pclk > > + resets: > + maxItems: 1 > + description: | Do not need '|' unless you need to preserve formatting. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml index 7aea255b301b..6d4f63f23f1a 100644 --- a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml +++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml @@ -50,6 +50,11 @@ properties: - const: wdog_clk - const: apb_pclk + resets: + maxItems: 1 + description: | + WDOGRESn input reset signal for sp805 module. + required: - compatible - reg @@ -67,4 +72,5 @@ examples: interrupts = <GIC_SPI 406 IRQ_TYPE_LEVEL_HIGH>; clocks = <&wdt_clk>, <&apb_pclk>; clock-names = "wdog_clk", "apb_pclk"; + resets = <&wdt_rst>; };