| Message ID | 20240215-mbly-i2c-v1-3-19a336e91dca@bootlin.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add Mobileye EyeQ5 support to the Nomadik I2C controller & use hrtimers for timeouts | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 15/02/2024 17:52, Théo Lebrun wrote: > Declare optional label devicetree property. Show usage in one example > with dummy name. > > To: Jean Delvare <jdelvare@suse.com> > To: Guenter Roeck <linux@roeck-us.net> > Cc: <linux-hwmon@vger.kernel.org> > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 16/02/2024 08:41, Krzysztof Kozlowski wrote: > On 15/02/2024 17:52, Théo Lebrun wrote: >> Declare optional label devicetree property. Show usage in one example >> with dummy name. >> >> To: Jean Delvare <jdelvare@suse.com> >> To: Guenter Roeck <linux@roeck-us.net> >> Cc: <linux-hwmon@vger.kernel.org> >> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> >> --- > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Although you might need to re-work this patch if this gets accepted: https://lore.kernel.org/linux-devicetree/20240216-dt-bindings-hwmon-common-v1-0-3c2c24ff1260@linaro.org/T/#m341d8f47ca5badd2637cd662fb331f144e16a54c Best regards, Krzysztof
Hello, On Fri Feb 16, 2024 at 9:00 AM CET, Krzysztof Kozlowski wrote: > On 16/02/2024 08:41, Krzysztof Kozlowski wrote: > > On 15/02/2024 17:52, Théo Lebrun wrote: > >> Declare optional label devicetree property. Show usage in one example > >> with dummy name. > >> > >> To: Jean Delvare <jdelvare@suse.com> > >> To: Guenter Roeck <linux@roeck-us.net> > >> Cc: <linux-hwmon@vger.kernel.org> > >> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > >> --- > > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > Although you might need to re-work this patch if this gets accepted: > > https://lore.kernel.org/linux-devicetree/20240216-dt-bindings-hwmon-common-v1-0-3c2c24ff1260@linaro.org/T/#m341d8f47ca5badd2637cd662fb331f144e16a54c Cool that this is made generic. Do not hesitate to Cc me in follow-ups. Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On Thu, Feb 15, 2024 at 05:52:10PM +0100, Théo Lebrun wrote: > Declare optional label devicetree property. Show usage in one example > with dummy name. > > To: Jean Delvare <jdelvare@suse.com> > To: Guenter Roeck <linux@roeck-us.net> > Cc: <linux-hwmon@vger.kernel.org> > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> What is the verdict here ? Should I apply it and accept another patch to update it, or should it be reworked to be based on the new common hwmon schema ? Thanks, Guenter > --- > Documentation/devicetree/bindings/hwmon/lm75.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/hwmon/lm75.yaml b/Documentation/devicetree/bindings/hwmon/lm75.yaml > index ed269e428a3d..5ca2c83b413d 100644 > --- a/Documentation/devicetree/bindings/hwmon/lm75.yaml > +++ b/Documentation/devicetree/bindings/hwmon/lm75.yaml > @@ -52,6 +52,9 @@ properties: > interrupts: > maxItems: 1 > > + label: > + description: user-facing name of the hardware monitor > + > required: > - compatible > - reg > @@ -83,6 +86,7 @@ examples: > compatible = "st,stlm75"; > reg = <0x48>; > vs-supply = <&vs>; > + label = "CPU temp"; > }; > }; > - |
On 24/02/2024 18:30, Guenter Roeck wrote: > On Thu, Feb 15, 2024 at 05:52:10PM +0100, Théo Lebrun wrote: >> Declare optional label devicetree property. Show usage in one example >> with dummy name. >> >> To: Jean Delvare <jdelvare@suse.com> >> To: Guenter Roeck <linux@roeck-us.net> >> Cc: <linux-hwmon@vger.kernel.org> >> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > What is the verdict here ? Should I apply it and accept another patch > to update it, or should it be reworked to be based on the new common > hwmon schema ? This should be reworked based on the new common schema (just like my follow up patches did for some of the bindings). Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/hwmon/lm75.yaml b/Documentation/devicetree/bindings/hwmon/lm75.yaml index ed269e428a3d..5ca2c83b413d 100644 --- a/Documentation/devicetree/bindings/hwmon/lm75.yaml +++ b/Documentation/devicetree/bindings/hwmon/lm75.yaml @@ -52,6 +52,9 @@ properties: interrupts: maxItems: 1 + label: + description: user-facing name of the hardware monitor + required: - compatible - reg @@ -83,6 +86,7 @@ examples: compatible = "st,stlm75"; reg = <0x48>; vs-supply = <&vs>; + label = "CPU temp"; }; }; - |
Declare optional label devicetree property. Show usage in one example with dummy name. To: Jean Delvare <jdelvare@suse.com> To: Guenter Roeck <linux@roeck-us.net> Cc: <linux-hwmon@vger.kernel.org> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> --- Documentation/devicetree/bindings/hwmon/lm75.yaml | 4 ++++ 1 file changed, 4 insertions(+)