diff mbox series

[3/7] dt-bindings: display: Document ST7703 panel rotation

Message ID 20240212184950.52210-4-macroalpha82@gmail.com
State Not Applicable, archived
Headers show
Series Add Support for RK3566 Powkiddy RGB10MAX3 | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Chris Morgan Feb. 12, 2024, 6:49 p.m. UTC 
From: Chris Morgan <macromorgan@hotmail.com>

Document the rotation property for ST7703 based panels.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 .../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Guido Günther Feb. 13, 2024, 8:04 a.m. UTC | #1 
Hi,
On Mon, Feb 12, 2024 at 12:49:46PM -0600, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Document the rotation property for ST7703 based panels.
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  .../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
> index 8dfe8951bf5b..97e0d14790e3 100644
> --- a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
> @@ -46,6 +46,8 @@ properties:
>  
>    backlight: true
>  
> +  rotation: true
> +

I'd avoid newlines here:

  backlight: true
  rotation: true

(which also seems to match what other panels do). With that

Reviewd-by: Guido Günther <agx@sigxcpu.org>

Cheers,
 -- Guido


>  required:
>    - compatible
>    - reg
> -- 
> 2.34.1
>
Krzysztof Kozlowski Feb. 13, 2024, 11:51 a.m. UTC | #2 
On 12/02/2024 19:49, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Document the rotation property for ST7703 based panels.
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

(with or without empty line removal)

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
index 8dfe8951bf5b..97e0d14790e3 100644
--- a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
+++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
@@ -46,6 +46,8 @@  properties:
 
   backlight: true
 
+  rotation: true
+
 required:
   - compatible
   - reg