| Message ID | 20240130125748.54194-1-aakarsh.jain@samsung.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: media: s5p-mfc: Remove s5p-mfc.txt binding | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On 30/01/2024 13:57, Aakarsh Jain wrote: > Commit "538af6e5856b" which convert s5p-mfc bindings to Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > json-schema is already merged. Remove "s5p-mfc.txt" file. > > Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com> > --- > Documentation/devicetree/bindings/media/s5p-mfc.txt | 0 Why you did not remove it in the first place? Your diff from 538af6e5856b is so confusing. Best regards, Krzysztof
On 30/01/2024 15:25, Krzysztof Kozlowski wrote: > On 30/01/2024 13:57, Aakarsh Jain wrote: >> Commit "538af6e5856b" which convert s5p-mfc bindings to > > Please run scripts/checkpatch.pl and fix reported warnings. Some > warnings can be ignored, but the code here looks like it needs a fix. > Feel free to get in touch if the warning is not clear. > >> json-schema is already merged. Remove "s5p-mfc.txt" file. >> >> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com> >> --- >> Documentation/devicetree/bindings/media/s5p-mfc.txt | 0 > > Why you did not remove it in the first place? Your diff from > 538af6e5856b is so confusing. Also, add fixes tag. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 30 January 2024 19:57 > To: Aakarsh Jain <aakarsh.jain@samsung.com>; linux-arm- > kernel@lists.infradead.org; linux-media@vger.kernel.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org > Cc: m.szyprowski@samsung.com; andrzej.hajda@intel.com; > mchehab@kernel.org; hverkuil-cisco@xs4all.nl; > krzysztof.kozlowski+dt@linaro.org; robh+dt@kernel.org; > conor+dt@kernel.org; linux-samsung-soc@vger.kernel.org; > andi@etezian.org; gost.dev@samsung.com; alim.akhtar@samsung.com; > pankaj.dubey@samsung.com > Subject: Re: [PATCH] dt-bindings: media: s5p-mfc: Remove s5p-mfc.txt > binding > > On 30/01/2024 15:25, Krzysztof Kozlowski wrote: > > On 30/01/2024 13:57, Aakarsh Jain wrote: > >> Commit "538af6e5856b" which convert s5p-mfc bindings to > > > > Please run scripts/checkpatch.pl and fix reported warnings. Some > > warnings can be ignored, but the code here looks like it needs a fix. > > Feel free to get in touch if the warning is not clear. > > I am getting below warning while running scripts/checkpatch.pl on this patch WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: deleted file mode 100644 total: 0 errors, 1 warnings, 0 lines checked I think this can be ignored. > >> json-schema is already merged. Remove "s5p-mfc.txt" file. > >> > >> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com> > >> --- > >> Documentation/devicetree/bindings/media/s5p-mfc.txt | 0 > > > > Why you did not remove it in the first place? Your diff from > > 538af6e5856b is so confusing. > I missed it before. Will add Fixes tag. > Also, add fixes tag. > Sure. Thanks for review! > Best regards, > Krzysztof
On 31/01/2024 07:06, Aakarsh Jain wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 30 January 2024 19:57 >> To: Aakarsh Jain <aakarsh.jain@samsung.com>; linux-arm- >> kernel@lists.infradead.org; linux-media@vger.kernel.org; linux- >> kernel@vger.kernel.org; devicetree@vger.kernel.org >> Cc: m.szyprowski@samsung.com; andrzej.hajda@intel.com; >> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; >> krzysztof.kozlowski+dt@linaro.org; robh+dt@kernel.org; >> conor+dt@kernel.org; linux-samsung-soc@vger.kernel.org; >> andi@etezian.org; gost.dev@samsung.com; alim.akhtar@samsung.com; >> pankaj.dubey@samsung.com >> Subject: Re: [PATCH] dt-bindings: media: s5p-mfc: Remove s5p-mfc.txt >> binding >> >> On 30/01/2024 15:25, Krzysztof Kozlowski wrote: >>> On 30/01/2024 13:57, Aakarsh Jain wrote: >>>> Commit "538af6e5856b" which convert s5p-mfc bindings to >>> >>> Please run scripts/checkpatch.pl and fix reported warnings. Some >>> warnings can be ignored, but the code here looks like it needs a fix. >>> Feel free to get in touch if the warning is not clear. >>> > I am getting below warning while running scripts/checkpatch.pl on this patch > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #18: > deleted file mode 100644 > > total: 0 errors, 1 warnings, 0 lines checked This one can be ignored, but your commit syntax does not look right. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt b/Documentation/devicetree/bindings/media/s5p-mfc.txt deleted file mode 100644 index e69de29bb2d1..000000000000
Commit "538af6e5856b" which convert s5p-mfc bindings to json-schema is already merged. Remove "s5p-mfc.txt" file. Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com> --- Documentation/devicetree/bindings/media/s5p-mfc.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 Documentation/devicetree/bindings/media/s5p-mfc.txt