| Message ID | 20231213154721.5037-1-zajec5@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/2] dt-bindings: nvmem: add "data-size" property | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 13.12.2023 16:47, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > Allow specifying NVMEM device content size in case it differs from > device total size. > > Cc: Christian Marangi <ansuelsmth@gmail.com> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> I forgot to link Rob's comment where he suggested we may need such a property: https://patchwork.ozlabs.org/comment/3154781/ Let's now see if I got it right. > --- > Documentation/devicetree/bindings/nvmem/nvmem.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documentation/devicetree/bindings/nvmem/nvmem.yaml > index 4fd015d402ce..095aed4250de 100644 > --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml > +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml > @@ -26,6 +26,13 @@ properties: > "#size-cells": > const: 1 > > + data-size: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + NVMEM device actual data (content) size. It may be need to be specified > + if it differs by design from the total NVMEM device size and it's > + impossible to determine it on runtime. > + > read-only: > $ref: /schemas/types.yaml#/definitions/flag > description:
On Wed, Dec 13, 2023 at 04:47:20PM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > Allow specifying NVMEM device content size in case it differs from > device total size. > > Cc: Christian Marangi <ansuelsmth@gmail.com> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > Documentation/devicetree/bindings/nvmem/nvmem.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documentation/devicetree/bindings/nvmem/nvmem.yaml > index 4fd015d402ce..095aed4250de 100644 > --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml > +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml > @@ -26,6 +26,13 @@ properties: > "#size-cells": > const: 1 > > + data-size: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + NVMEM device actual data (content) size. It may be need to be specified > + if it differs by design from the total NVMEM device size and it's > + impossible to determine it on runtime. 'data-size' is already defined in Documentation/devicetree/bindings/eeprom/microchip,93lc46b.yaml. That would be fine, but it's defining bits per word. So I think it's better if we call this something else. 'total-data-size' or 'actual-data-size'? I think Simon had something similar for binman. Rob
diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documentation/devicetree/bindings/nvmem/nvmem.yaml index 4fd015d402ce..095aed4250de 100644 --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml @@ -26,6 +26,13 @@ properties: "#size-cells": const: 1 + data-size: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + NVMEM device actual data (content) size. It may be need to be specified + if it differs by design from the total NVMEM device size and it's + impossible to determine it on runtime. + read-only: $ref: /schemas/types.yaml#/definitions/flag description: