| Message ID | 20231212164004.1683589-2-ninad@linux.ibm.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add device tree for IBM system1 BMC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, Dec 12, 2023 at 10:39:57AM -0600, Ninad Palsule wrote: > Document the new compatibles used on IBM system1-bmc > > Tested: > This board is tested using the simics simulator. I don't see how this is relevant to dt-bindings patches. > > Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> > --- > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ IMO these should be split into two patches. Cheers, Conor. > 2 files changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > index 6f7543463d89..ebebe14c42aa 100644 > --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > @@ -85,6 +85,7 @@ properties: > - facebook,yosemite4-bmc > - ibm,everest-bmc > - ibm,rainier-bmc > + - ibm,system1-bmc > - ibm,tacoma-bmc > - inventec,starscream-bmc > - inventec,transformer-bmc > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 441b55723675..b12a60d2eb0f 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -135,6 +135,8 @@ properties: > - ibm,cffps1 > # IBM Common Form Factor Power Supply Versions 2 > - ibm,cffps2 > + # Infineon barometric pressure and temperature sensor > + - infineon,dps310 > # Infineon IR36021 digital POL buck controller > - infineon,ir36021 > # Infineon IR38060 Voltage Regulator > -- > 2.39.2 >
Hello Conor, On 12/12/23 11:09, Conor Dooley wrote: > On Tue, Dec 12, 2023 at 10:39:57AM -0600, Ninad Palsule wrote: >> Document the new compatibles used on IBM system1-bmc >> >> Tested: >> This board is tested using the simics simulator. > I don't see how this is relevant to dt-bindings patches. Make sense. Removed it. > >> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> >> --- >> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + >> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > IMO these should be split into two patches. Make sense. Split it into two patches. Thank you for the review. Thanks & Regards, Ninad > > Cheers, > Conor. > >> 2 files changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> index 6f7543463d89..ebebe14c42aa 100644 >> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> @@ -85,6 +85,7 @@ properties: >> - facebook,yosemite4-bmc >> - ibm,everest-bmc >> - ibm,rainier-bmc >> + - ibm,system1-bmc >> - ibm,tacoma-bmc >> - inventec,starscream-bmc >> - inventec,transformer-bmc >> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml >> index 441b55723675..b12a60d2eb0f 100644 >> --- a/Documentation/devicetree/bindings/trivial-devices.yaml >> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml >> @@ -135,6 +135,8 @@ properties: >> - ibm,cffps1 >> # IBM Common Form Factor Power Supply Versions 2 >> - ibm,cffps2 >> + # Infineon barometric pressure and temperature sensor >> + - infineon,dps310 >> # Infineon IR36021 digital POL buck controller >> - infineon,ir36021 >> # Infineon IR38060 Voltage Regulator >> -- >> 2.39.2 >>
On Tue Dec 12, 2023 at 6:39 PM EET, Ninad Palsule wrote: > Document the new compatibles used on IBM system1-bmc > > Tested: this not very useful line :-) (nit) > This board is tested using the simics simulator. Just leave this (w/o indentation) > > Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> > --- > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > index 6f7543463d89..ebebe14c42aa 100644 > --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > @@ -85,6 +85,7 @@ properties: > - facebook,yosemite4-bmc > - ibm,everest-bmc > - ibm,rainier-bmc > + - ibm,system1-bmc > - ibm,tacoma-bmc > - inventec,starscream-bmc > - inventec,transformer-bmc > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 441b55723675..b12a60d2eb0f 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -135,6 +135,8 @@ properties: > - ibm,cffps1 > # IBM Common Form Factor Power Supply Versions 2 > - ibm,cffps2 > + # Infineon barometric pressure and temperature sensor > + - infineon,dps310 > # Infineon IR36021 digital POL buck controller > - infineon,ir36021 > # Infineon IR38060 Voltage Regulator BR, Jarkko
Hello Jarkko, On 12/13/23 12:18, Jarkko Sakkinen wrote: > On Tue Dec 12, 2023 at 6:39 PM EET, Ninad Palsule wrote: >> Document the new compatibles used on IBM system1-bmc >> >> Tested: > this not very useful line :-) (nit) > >> This board is tested using the simics simulator. > Just leave this (w/o indentation) Based on Conor's suggestion, I have removed both lines. Thanks for the review. Thanks & Regards, Ninad > >> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> >> --- >> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + >> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ >> 2 files changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> index 6f7543463d89..ebebe14c42aa 100644 >> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> @@ -85,6 +85,7 @@ properties: >> - facebook,yosemite4-bmc >> - ibm,everest-bmc >> - ibm,rainier-bmc >> + - ibm,system1-bmc >> - ibm,tacoma-bmc >> - inventec,starscream-bmc >> - inventec,transformer-bmc >> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml >> index 441b55723675..b12a60d2eb0f 100644 >> --- a/Documentation/devicetree/bindings/trivial-devices.yaml >> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml >> @@ -135,6 +135,8 @@ properties: >> - ibm,cffps1 >> # IBM Common Form Factor Power Supply Versions 2 >> - ibm,cffps2 >> + # Infineon barometric pressure and temperature sensor >> + - infineon,dps310 >> # Infineon IR36021 digital POL buck controller >> - infineon,ir36021 >> # Infineon IR38060 Voltage Regulator > BR, Jarkko
diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index 6f7543463d89..ebebe14c42aa 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -85,6 +85,7 @@ properties: - facebook,yosemite4-bmc - ibm,everest-bmc - ibm,rainier-bmc + - ibm,system1-bmc - ibm,tacoma-bmc - inventec,starscream-bmc - inventec,transformer-bmc diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 441b55723675..b12a60d2eb0f 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -135,6 +135,8 @@ properties: - ibm,cffps1 # IBM Common Form Factor Power Supply Versions 2 - ibm,cffps2 + # Infineon barometric pressure and temperature sensor + - infineon,dps310 # Infineon IR36021 digital POL buck controller - infineon,ir36021 # Infineon IR38060 Voltage Regulator
Document the new compatibles used on IBM system1-bmc Tested: This board is tested using the simics simulator. Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> --- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 2 files changed, 3 insertions(+)