| Message ID | 20231206155740.5278-3-biju.das.jz@bp.renesas.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Convert DA906{1,2} bindings to json-schema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 06/12/2023 16:57, Biju Das wrote: > The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes > are required. The fallback compatible string "dlg,da9062-watchdog" will be > used on DA9061 watchdog. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v3->v4: > * Dropped comment for d9061 watchdog fallback. > * Replaced enum->const for dlg,da9061-watchdog and its fallback. > v2->v3: > * No change > v2: > * New patch > --- > .../bindings/watchdog/dlg,da9062-watchdog.yaml | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml > index f058628bb632..7c63b99dac85 100644 > --- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml > +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml > @@ -14,9 +14,13 @@ allOf: > > properties: > compatible: > - enum: > - - dlg,da9061-watchdog > - - dlg,da9062-watchdog > + oneOf: > + - items: Drop items, just enum. Easier to read so usually we keep such syntax for compatibles. > + - enum: > + - dlg,da9062-watchdog > + - items: > + - const: dlg,da9061-watchdog > + - const: dlg,da9062-watchdog Best regards, Krzysztof
Hi Krzysztof Kozlowski, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Thursday, December 7, 2023 8:35 AM > Subject: Re: [PATCH v4 2/8] dt-bindings: watchdog: dlg,da9062-watchdog: > Add fallback for DA9061 watchdog > > On 06/12/2023 16:57, Biju Das wrote: > > The DA9061 watchdog is identical to DA9062 watchdog, so no driver > > changes are required. The fallback compatible string > > "dlg,da9062-watchdog" will be used on DA9061 watchdog. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > v3->v4: > > * Dropped comment for d9061 watchdog fallback. > > * Replaced enum->const for dlg,da9061-watchdog and its fallback. > > v2->v3: > > * No change > > v2: > > * New patch > > --- > > .../bindings/watchdog/dlg,da9062-watchdog.yaml | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml > > b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml > > index f058628bb632..7c63b99dac85 100644 > > --- > > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.y > > +++ aml > > @@ -14,9 +14,13 @@ allOf: > > > > properties: > > compatible: > > - enum: > > - - dlg,da9061-watchdog > > - - dlg,da9062-watchdog > > + oneOf: > > + - items: > > Drop items, just enum. Easier to read so usually we keep such syntax for > compatibles. OK will do. Cheers, Biju > > > + - enum: > > + - dlg,da9062-watchdog > > + - items: > > + - const: dlg,da9061-watchdog > > + - const: dlg,da9062-watchdog > > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml index f058628bb632..7c63b99dac85 100644 --- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml @@ -14,9 +14,13 @@ allOf: properties: compatible: - enum: - - dlg,da9061-watchdog - - dlg,da9062-watchdog + oneOf: + - items: + - enum: + - dlg,da9062-watchdog + - items: + - const: dlg,da9061-watchdog + - const: dlg,da9062-watchdog dlg,use-sw-pm: type: boolean
The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes are required. The fallback compatible string "dlg,da9062-watchdog" will be used on DA9061 watchdog. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- v3->v4: * Dropped comment for d9061 watchdog fallback. * Replaced enum->const for dlg,da9061-watchdog and its fallback. v2->v3: * No change v2: * New patch --- .../bindings/watchdog/dlg,da9062-watchdog.yaml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)