| Message ID | 20231029042712.520010-3-cristian.ciocaltea@collabora.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Enable networking support for StarFive JH7100 SoC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 29/10/2023 05:27, Cristian Ciocaltea wrote: > The usage of 'select' doesn't seem to have any influence on how this > binding schema is applied to the nodes, hence remove it. > It has. Why do you think it doesn't? You should see new errors from dwmac schema. Best regards, Krzysztof
On 10/29/23 13:18, Krzysztof Kozlowski wrote: > On 29/10/2023 05:27, Cristian Ciocaltea wrote: >> The usage of 'select' doesn't seem to have any influence on how this >> binding schema is applied to the nodes, hence remove it. >> > > It has. Why do you think it doesn't? You should see new errors from > dwmac schema. This patch came as a result of testing both variants (w/ and w/o 'select') with several different compatible strings and seeing consistent output: - "starfive,jh7110-dwmac", "invalid"; - "starfive,jh7110-dwmac"; - "invalid", "snps,dwmac-5.20"; - "invalid" Did I miss something? Thanks for the review, Cristian
On 29/10/2023 22:08, Cristian Ciocaltea wrote: > On 10/29/23 13:18, Krzysztof Kozlowski wrote: >> On 29/10/2023 05:27, Cristian Ciocaltea wrote: >>> The usage of 'select' doesn't seem to have any influence on how this >>> binding schema is applied to the nodes, hence remove it. >>> >> >> It has. Why do you think it doesn't? You should see new errors from >> dwmac schema. > > This patch came as a result of testing both variants (w/ and w/o > 'select') with several different compatible strings and seeing > consistent output: > > - "starfive,jh7110-dwmac", "invalid"; > - "starfive,jh7110-dwmac"; > - "invalid", "snps,dwmac-5.20"; > - "invalid" > > Did I miss something? Testing all bindings? The select is there to prevent matching unrelated bindings. Best regards, Krzysztof
On 10/30/23 09:27, Krzysztof Kozlowski wrote: > On 29/10/2023 22:08, Cristian Ciocaltea wrote: >> On 10/29/23 13:18, Krzysztof Kozlowski wrote: >>> On 29/10/2023 05:27, Cristian Ciocaltea wrote: >>>> The usage of 'select' doesn't seem to have any influence on how this >>>> binding schema is applied to the nodes, hence remove it. >>>> >>> >>> It has. Why do you think it doesn't? You should see new errors from >>> dwmac schema. >> >> This patch came as a result of testing both variants (w/ and w/o >> 'select') with several different compatible strings and seeing >> consistent output: >> >> - "starfive,jh7110-dwmac", "invalid"; >> - "starfive,jh7110-dwmac"; >> - "invalid", "snps,dwmac-5.20"; >> - "invalid" >> >> Did I miss something? > > Testing all bindings? The select is there to prevent matching unrelated > bindings. Indeed, my bad, as I've been using DT_SCHEMA_FILES to restrict the scope during initial testing and missed to include later other schemas for an extended validation (note that since [1] it's possible to specify a list of file paths separated by ':'). Will drop this in v3. [1] 25eba1598c8e ("dt-bindings: Fix multi pattern support in DT_SCHEMA_FILES") Thanks, Cristian
diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml index 5e7cfbbebce6..cc3e1c6fc135 100644 --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml @@ -11,15 +11,6 @@ maintainers: - Emil Renner Berthing <kernel@esmil.dk> - Samin Guo <samin.guo@starfivetech.com> -select: - properties: - compatible: - contains: - enum: - - starfive,jh7110-dwmac - required: - - compatible - properties: compatible: items:
The usage of 'select' doesn't seem to have any influence on how this binding schema is applied to the nodes, hence remove it. Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> --- .../devicetree/bindings/net/starfive,jh7110-dwmac.yaml | 9 --------- 1 file changed, 9 deletions(-)