| Message ID | 20231016023504.3976746-2-chris.packham@alliedtelesis.co.nz |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | i2c: mv64xxx: reset-gpios | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 16/10/2023 04:35, Chris Packham wrote: > Add reset-gpios and reset-delay-us properties to the marvell,mv64xxx-i2c > binding. These can be used to describe hardware where a common reset > GPIO is connected to all downstream devices on and I2C bus. This reset > will be released before the downstream devices on the bus are probed. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > > Notes: > Changes in v2: > - Update commit message > - Add reset-delay-us property > > .../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml > index 461d1c9ee3f7..7223797b0572 100644 > --- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml > @@ -70,6 +70,12 @@ properties: > resets: > maxItems: 1 > > + reset-gpios: > + maxItems: 1 > + > + reset-delay-us: > + description: Delay in us to wait after reset gpio de-assertion. Add: default: XXXX Best regards, Krzysztof
On Mon, Oct 16, 2023 at 03:35:03PM +1300, Chris Packham wrote: > Add reset-gpios and reset-delay-us properties to the marvell,mv64xxx-i2c > binding. These can be used to describe hardware where a common reset > GPIO is connected to all downstream devices on and I2C bus. This reset > will be released before the downstream devices on the bus are probed. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > > Notes: > Changes in v2: > - Update commit message > - Add reset-delay-us property > > .../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml > index 461d1c9ee3f7..7223797b0572 100644 > --- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml > @@ -70,6 +70,12 @@ properties: > resets: > maxItems: 1 > > + reset-gpios: > + maxItems: 1 It would be worth saying this is common for all downstream devices on the I2C bus here. > + > + reset-delay-us: > + description: Delay in us to wait after reset gpio de-assertion. > + > dmas: > items: > - description: RX DMA Channel > -- > 2.42.0 >
diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml index 461d1c9ee3f7..7223797b0572 100644 --- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml @@ -70,6 +70,12 @@ properties: resets: maxItems: 1 + reset-gpios: + maxItems: 1 + + reset-delay-us: + description: Delay in us to wait after reset gpio de-assertion. + dmas: items: - description: RX DMA Channel
Add reset-gpios and reset-delay-us properties to the marvell,mv64xxx-i2c binding. These can be used to describe hardware where a common reset GPIO is connected to all downstream devices on and I2C bus. This reset will be released before the downstream devices on the bus are probed. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- Notes: Changes in v2: - Update commit message - Add reset-delay-us property .../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 6 ++++++ 1 file changed, 6 insertions(+)