| Message ID | 20231011184823.443959-6-peter.griffin@linaro.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, Oct 11, 2023 at 1:49 PM Peter Griffin <peter.griffin@linaro.org> wrote: > > This introduces bindings and dt-schema for the Google tensor SoCs. > Currently just gs101 and pixel 6 are supported. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/arm/google.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/google.yaml > > diff --git a/Documentation/devicetree/bindings/arm/google.yaml b/Documentation/devicetree/bindings/arm/google.yaml > new file mode 100644 > index 000000000000..167945e4d5ee > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/google.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/google.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Google Tensor platforms > + > +maintainers: > + - Peter Griffin <peter.griffin@linaro.org> > + > +description: | > + ARM platforms using SoCs designed by Google branded "Tensor" used in Pixel > + devices. > + > + Currently upstream this is devices using "gs101" SoC which is found in Pixel > + 6, Pixel 6 Pro and Pixel 6a. > + > + Google have a few different names for the SoC. > + - Marketing name ("Tensor") > + - Codename ("Whitechapel") > + - SoC ID ("gs101") > + - Die ID ("S5P9845"); > + > + Likewise there are a couple of names for the actual device > + - Marketing name ("Pixel 6") > + - Codename ("Oriole") > + > + Devicetrees should use the lowercased SoC ID and lowercased board codename. > + e.g. gs101 and gs101-oriole > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + Is that empty line is actually needed here? > + - description: Google Pixel 6 / Oriole > + items: > + - enum: > + - google,gs101-oriole > + - const: google,gs101 > + > +additionalProperties: true > + > +... > -- > 2.42.0.655.g421f12c284-goog >
Hi Sam, Thanks for the review. On Thu, 12 Oct 2023 at 00:06, Sam Protsenko <semen.protsenko@linaro.org> wrote: > > On Wed, Oct 11, 2023 at 1:49 PM Peter Griffin <peter.griffin@linaro.org> wrote: > > > > This introduces bindings and dt-schema for the Google tensor SoCs. > > Currently just gs101 and pixel 6 are supported. > > > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > .../devicetree/bindings/arm/google.yaml | 46 +++++++++++++++++++ > > 1 file changed, 46 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/google.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/google.yaml b/Documentation/devicetree/bindings/arm/google.yaml > > new file mode 100644 > > index 000000000000..167945e4d5ee > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/google.yaml > > @@ -0,0 +1,46 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/arm/google.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Google Tensor platforms > > + > > +maintainers: > > + - Peter Griffin <peter.griffin@linaro.org> > > + > > +description: | > > + ARM platforms using SoCs designed by Google branded "Tensor" used in Pixel > > + devices. > > + > > + Currently upstream this is devices using "gs101" SoC which is found in Pixel > > + 6, Pixel 6 Pro and Pixel 6a. > > + > > + Google have a few different names for the SoC. > > + - Marketing name ("Tensor") > > + - Codename ("Whitechapel") > > + - SoC ID ("gs101") > > + - Die ID ("S5P9845"); > > + > > + Likewise there are a couple of names for the actual device > > + - Marketing name ("Pixel 6") > > + - Codename ("Oriole") > > + > > + Devicetrees should use the lowercased SoC ID and lowercased board codename. > > + e.g. gs101 and gs101-oriole > > + > > +properties: > > + $nodename: > > + const: '/' > > + compatible: > > + oneOf: > > + > > Is that empty line is actually needed here? Will fix in v4. Peter
diff --git a/Documentation/devicetree/bindings/arm/google.yaml b/Documentation/devicetree/bindings/arm/google.yaml new file mode 100644 index 000000000000..167945e4d5ee --- /dev/null +++ b/Documentation/devicetree/bindings/arm/google.yaml @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/google.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Google Tensor platforms + +maintainers: + - Peter Griffin <peter.griffin@linaro.org> + +description: | + ARM platforms using SoCs designed by Google branded "Tensor" used in Pixel + devices. + + Currently upstream this is devices using "gs101" SoC which is found in Pixel + 6, Pixel 6 Pro and Pixel 6a. + + Google have a few different names for the SoC. + - Marketing name ("Tensor") + - Codename ("Whitechapel") + - SoC ID ("gs101") + - Die ID ("S5P9845"); + + Likewise there are a couple of names for the actual device + - Marketing name ("Pixel 6") + - Codename ("Oriole") + + Devicetrees should use the lowercased SoC ID and lowercased board codename. + e.g. gs101 and gs101-oriole + +properties: + $nodename: + const: '/' + compatible: + oneOf: + + - description: Google Pixel 6 / Oriole + items: + - enum: + - google,gs101-oriole + - const: google,gs101 + +additionalProperties: true + +...