| Message ID | 20231011184823.443959-5-peter.griffin@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, Oct 11, 2023 at 1:49 PM Peter Griffin <peter.griffin@linaro.org> wrote: > > Add the "google,gs101-wdt" and "google,gs201-wdt" compatibles to the > dt-schema documentation. > > gs101 SoC has two CPU clusters and each cluster has its own dedicated > watchdog timer (similar to exynos850 and exynosautov9 SoCs). > > These WDT instances are controlled using different bits in PMU > registers. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > .../devicetree/bindings/watchdog/samsung-wdt.yaml | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml > index 8fb6656ba0c2..67c8767f0499 100644 > --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml > @@ -17,6 +17,8 @@ description: |+ > properties: > compatible: > enum: > + - google,gs101-wdt # for Google gs101 > + - google,gs201-wdt # for Google gs201 > - samsung,s3c2410-wdt # for S3C2410 > - samsung,s3c6410-wdt # for S3C6410, S5PV210 and Exynos4 > - samsung,exynos5250-wdt # for Exynos5250 > @@ -42,13 +44,13 @@ properties: > samsung,cluster-index: > $ref: /schemas/types.yaml#/definitions/uint32 > description: > - Index of CPU cluster on which watchdog is running (in case of Exynos850) > + Index of CPU cluster on which watchdog is running (in case of Exynos850 or Google gsx01) Please stick to 80 characters per line when possible. > > samsung,syscon-phandle: > $ref: /schemas/types.yaml#/definitions/phandle > description: > Phandle to the PMU system controller node (in case of Exynos5250, > - Exynos5420, Exynos7 and Exynos850). > + Exynos5420, Exynos7, Exynos850 and gsx01). > > required: > - compatible > @@ -69,6 +71,8 @@ allOf: > - samsung,exynos7-wdt > - samsung,exynos850-wdt > - samsung,exynosautov9-wdt > + - google,gs101-wdt > + - google,gs201-wdt > then: > required: > - samsung,syscon-phandle > @@ -79,6 +83,8 @@ allOf: > enum: > - samsung,exynos850-wdt > - samsung,exynosautov9-wdt > + - google,gs101-wdt > + - google,gs201-wdt > then: > properties: > clocks: > -- > 2.42.0.655.g421f12c284-goog >
Hi Sam, Thanks for the review. On Wed, 11 Oct 2023 at 23:58, Sam Protsenko <semen.protsenko@linaro.org> wrote: > > On Wed, Oct 11, 2023 at 1:49 PM Peter Griffin <peter.griffin@linaro.org> wrote: > > > > Add the "google,gs101-wdt" and "google,gs201-wdt" compatibles to the > > dt-schema documentation. > > > > gs101 SoC has two CPU clusters and each cluster has its own dedicated > > watchdog timer (similar to exynos850 and exynosautov9 SoCs). > > > > These WDT instances are controlled using different bits in PMU > > registers. > > > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > > --- > > .../devicetree/bindings/watchdog/samsung-wdt.yaml | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml > > index 8fb6656ba0c2..67c8767f0499 100644 > > --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml > > @@ -17,6 +17,8 @@ description: |+ > > properties: > > compatible: > > enum: > > + - google,gs101-wdt # for Google gs101 > > + - google,gs201-wdt # for Google gs201 > > - samsung,s3c2410-wdt # for S3C2410 > > - samsung,s3c6410-wdt # for S3C6410, S5PV210 and Exynos4 > > - samsung,exynos5250-wdt # for Exynos5250 > > @@ -42,13 +44,13 @@ properties: > > samsung,cluster-index: > > $ref: /schemas/types.yaml#/definitions/uint32 > > description: > > - Index of CPU cluster on which watchdog is running (in case of Exynos850) > > + Index of CPU cluster on which watchdog is running (in case of Exynos850 or Google gsx01) > > Please stick to 80 characters per line when possible. Will fix in v4. Peter
diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml index 8fb6656ba0c2..67c8767f0499 100644 --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml @@ -17,6 +17,8 @@ description: |+ properties: compatible: enum: + - google,gs101-wdt # for Google gs101 + - google,gs201-wdt # for Google gs201 - samsung,s3c2410-wdt # for S3C2410 - samsung,s3c6410-wdt # for S3C6410, S5PV210 and Exynos4 - samsung,exynos5250-wdt # for Exynos5250 @@ -42,13 +44,13 @@ properties: samsung,cluster-index: $ref: /schemas/types.yaml#/definitions/uint32 description: - Index of CPU cluster on which watchdog is running (in case of Exynos850) + Index of CPU cluster on which watchdog is running (in case of Exynos850 or Google gsx01) samsung,syscon-phandle: $ref: /schemas/types.yaml#/definitions/phandle description: Phandle to the PMU system controller node (in case of Exynos5250, - Exynos5420, Exynos7 and Exynos850). + Exynos5420, Exynos7, Exynos850 and gsx01). required: - compatible @@ -69,6 +71,8 @@ allOf: - samsung,exynos7-wdt - samsung,exynos850-wdt - samsung,exynosautov9-wdt + - google,gs101-wdt + - google,gs201-wdt then: required: - samsung,syscon-phandle @@ -79,6 +83,8 @@ allOf: enum: - samsung,exynos850-wdt - samsung,exynosautov9-wdt + - google,gs101-wdt + - google,gs201-wdt then: properties: clocks:
Add the "google,gs101-wdt" and "google,gs201-wdt" compatibles to the dt-schema documentation. gs101 SoC has two CPU clusters and each cluster has its own dedicated watchdog timer (similar to exynos850 and exynosautov9 SoCs). These WDT instances are controlled using different bits in PMU registers. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- .../devicetree/bindings/watchdog/samsung-wdt.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)