| Message ID | 20230916110902.234273-4-arinc.unal@arinc9.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | define and enforce phylink bindings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 37 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml index cfd69c2604ea..7eb025df0df8 100644 --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml @@ -109,18 +109,19 @@ if: then: $ref: /schemas/spi/spi-peripheral-props.yaml# - not: - required: - - mdc-gpios - - mdio-gpios - - mdio - properties: mdc-gpios: false mdio-gpios: false - mdio: false + mdio: + properties: + compatible: false else: + properties: + mdio: + required: + - compatible + required: - mdc-gpios - mdio-gpios @@ -130,11 +131,6 @@ else: required: - compatible - # - mdc-gpios - # - mdio-gpios - # - reset-gpios - # - mdio - unevaluatedProperties: false examples:
The MDIO controlled Realtek switches (distinguished by the reg property being used) are allowed to have their MDIO bus registered OF-based. Allow the mdio property for them. Only the SMI controlled Realtek switches require the compatible property of the mdio child node. Require it for them and disallow it for the MDIO controlled ones. Remove the unnecessary if:then:not:required rule and comments. Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- .../devicetree/bindings/net/dsa/realtek.yaml | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-)