| Message ID | 20230822145644.213589-3-sean@mess.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 10 lines checked |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Tue, 22 Aug 2023 15:56:44 +0100, Sean Young wrote: > The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir > can be removed. > > Cc: Sicelo <absicsz@gmail.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > Cc: Pali Rohár <pali.rohar@gmail.com> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: Timo Kokkonen <timo.t.kokkonen@iki.fi> > Cc: Tony Lindgren <tony@atomide.com> > Signed-off-by: Sean Young <sean@mess.org> > --- > .../bindings/leds/irled/pwm-ir-tx.yaml | 4 +++- > .../devicetree/bindings/media/nokia,n900-ir | 20 ------------------- > 2 files changed, 3 insertions(+), 21 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/media/nokia,n900-ir > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Traceback (most recent call last): File "/usr/local/bin/dt-doc-validate", line 64, in <module> ret |= check_doc(f) ^^^^^^^^^^^^ File "/usr/local/bin/dt-doc-validate", line 32, in check_doc for error in sorted(dtsch.iter_errors(), key=lambda e: e.linecol): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/dist-packages/dtschema/schema.py", line 135, in iter_errors self.annotate_error(scherr, meta_schema, scherr.schema_path) File "/usr/local/lib/python3.11/dist-packages/dtschema/schema.py", line 114, in annotate_error schema = schema[p] ~~~~~~^^^ KeyError: 'type' Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.example.dtb: /example-0/irled: failed to match any schema with compatible: ['pwm-ir-tx'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230822145644.213589-3-sean@mess.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.yaml b/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.yaml index f2a6fa140f38..dc19b6475ba8 100644 --- a/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.yaml +++ b/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.yaml @@ -15,7 +15,9 @@ description: properties: compatible: - const: pwm-ir-tx + - const: pwm-ir-tx + - const: nokia,n900-ir + deprecated: true pwms: maxItems: 1 diff --git a/Documentation/devicetree/bindings/media/nokia,n900-ir b/Documentation/devicetree/bindings/media/nokia,n900-ir deleted file mode 100644 index 13a18ce37dd1..000000000000 --- a/Documentation/devicetree/bindings/media/nokia,n900-ir +++ /dev/null @@ -1,20 +0,0 @@ -Device-Tree bindings for LIRC TX driver for Nokia N900(RX51) - -Required properties: - - compatible: should be "nokia,n900-ir". - - pwms: specifies PWM used for IR signal transmission. - -Example node: - - pwm9: dmtimer-pwm@9 { - compatible = "ti,omap-dmtimer-pwm"; - ti,timers = <&timer9>; - ti,clock-source = <0x00>; /* timer_sys_ck */ - #pwm-cells = <3>; - }; - - ir: n900-ir { - compatible = "nokia,n900-ir"; - - pwms = <&pwm9 0 26316 0>; /* 38000 Hz */ - };
The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir can be removed. Cc: Sicelo <absicsz@gmail.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Conor Dooley <conor+dt@kernel.org> Cc: devicetree@vger.kernel.org Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Cc: Pali Rohár <pali.rohar@gmail.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: Timo Kokkonen <timo.t.kokkonen@iki.fi> Cc: Tony Lindgren <tony@atomide.com> Signed-off-by: Sean Young <sean@mess.org> --- .../bindings/leds/irled/pwm-ir-tx.yaml | 4 +++- .../devicetree/bindings/media/nokia,n900-ir | 20 ------------------- 2 files changed, 3 insertions(+), 21 deletions(-) delete mode 100644 Documentation/devicetree/bindings/media/nokia,n900-ir