| Message ID | 20230718204217.651081-1-dinguyen@kernel.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | dt-bindings: reset: altr,modrst-offset is not required for arm64 SoCFPGA | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, Jul 18, 2023 at 03:42:17PM -0500, Dinh Nguyen wrote: > The property "altr,modrst-offset" is only applicable to arm32 SoCFPGA > platforms, thus it not required for all platforms. > > While at it, update my email address. > > Signed-off-by: Dinh Nguyen <dinguyen@kernel.org> > --- > .../devicetree/bindings/reset/altr,rst-mgr.yaml | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml b/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml > index 4379cec6b35a..7796408d2545 100644 > --- a/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml > +++ b/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml > @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > title: Altera SOCFPGA Reset Manager > > maintainers: > - - Dinh Nguyen <dinguyen@altera.com> > + - Dinh Nguyen <dinguyen@kernel.org> > > properties: > compatible: > @@ -32,9 +32,20 @@ properties: > required: > - compatible > - reg > - - altr,modrst-offset > - '#reset-cells' > > +if: > + properties: > + compatible: > + contains: > + const: altr,stratix10-rst-mgr > +then: > + properties: > + altr,modrst-offset: false > +else: > + properties: > + altr,modrst-offset: true You don't need the else clause. "altr,modrst-offset" is already allowed by default. Rob
diff --git a/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml b/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml index 4379cec6b35a..7796408d2545 100644 --- a/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml +++ b/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: Altera SOCFPGA Reset Manager maintainers: - - Dinh Nguyen <dinguyen@altera.com> + - Dinh Nguyen <dinguyen@kernel.org> properties: compatible: @@ -32,9 +32,20 @@ properties: required: - compatible - reg - - altr,modrst-offset - '#reset-cells' +if: + properties: + compatible: + contains: + const: altr,stratix10-rst-mgr +then: + properties: + altr,modrst-offset: false +else: + properties: + altr,modrst-offset: true + additionalProperties: false examples:
The property "altr,modrst-offset" is only applicable to arm32 SoCFPGA platforms, thus it not required for all platforms. While at it, update my email address. Signed-off-by: Dinh Nguyen <dinguyen@kernel.org> --- .../devicetree/bindings/reset/altr,rst-mgr.yaml | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)