Message ID | 20230607115508.2964574-3-l.goehrs@pengutronix.de |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | [v1,1/8] dt-bindings: display: panel: mipi-dbi-spi: add shineworld lh133k compatible | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/patch-applied | success | |
robh/dtbs-check | warning | build log |
robh/dt-meta-schema | success |
Wed, Jun 07, 2023 at 01:55:02PM +0200, Leonard Göhrs kirjoitti: > This patch allows giving each of the controller's pins a meaningful > name. Isn't it gpio.txt already mentiones this? Perhaps you need to convert that to YAML and use it here?
On 07/06/2023 18:36, andy.shevchenko@gmail.com wrote: > Wed, Jun 07, 2023 at 01:55:02PM +0200, Leonard Göhrs kirjoitti: >> This patch allows giving each of the controller's pins a meaningful >> name. > > Isn't it gpio.txt already mentiones this? TXT does not matter for DT schema. It's is already covered by dtschemas. > Perhaps you need to convert that to YAML and use it here? How would it solve anything? We still want constraints, right? Best regards, Krzysztof
On 07/06/2023 13:55, Leonard Göhrs wrote: > This patch allows giving each of the controller's pins a meaningful > name. > > Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, Jun 7, 2023 at 1:57 PM Leonard Göhrs <l.goehrs@pengutronix.de> wrote: > > This patch allows giving each of the controller's pins a meaningful > name. > > Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de> > --- > Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml > index 5b0134304e51c..452f8972a9659 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml > +++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml > @@ -24,6 +24,10 @@ properties: > '#gpio-cells': > const: 2 > > + gpio-line-names: > + minItems: 4 > + maxItems: 8 > + > required: > - compatible > - reg > -- > 2.39.2 > Applied, thanks! Bart
diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml index 5b0134304e51c..452f8972a9659 100644 --- a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml +++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml @@ -24,6 +24,10 @@ properties: '#gpio-cells': const: 2 + gpio-line-names: + minItems: 4 + maxItems: 8 + required: - compatible - reg
This patch allows giving each of the controller's pins a meaningful name. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de> --- Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 4 ++++ 1 file changed, 4 insertions(+)