| Message ID | 20230424123522.18302-6-nikita.shubin@maquefel.me |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | ep93xx device tree conversion | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 24/04/2023 14:34, Nikita Shubin wrote: > This adds device tree bindings for the Cirrus Logic EP93xx > timer block used in these SoCs. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> Subject: drop second/last, redundant "DT bindings for". The "dt-bindings" prefix is already stating that these are bindings. In all patches. > --- > > Notes: > Arnd Bergmann: > - replaced ep93xx wildcard with ep9301 > > .../bindings/timer/cirrus,ep93xx-timer.yaml | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml > > diff --git a/Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml b/Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml > new file mode 100644 > index 000000000000..ce8b8a5cb90a > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/timer/cirrus,ep93xx-timer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus Logic EP93xx timers bindings Drop "bindings". In all patches. > + > +maintainers: > + - Hartley Sweeten <hsweeten@visionengravers.com> > + - Alexander Sverdlin <alexander.sverdlin@gmail.com> > + > +properties: > + compatible: > + const: cirrus,ep9301-timer > + With two fixes above: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This is an automated instruction, just in case, because many review tags are being ignored. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 Best regards, Krzysztof
On 24/04/2023 14:34, Nikita Shubin wrote: > This adds device tree bindings for the Cirrus Logic EP93xx > timer block used in these SoCs. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > --- > > Notes: > Arnd Bergmann: > - replaced ep93xx wildcard with ep9301 > > .../bindings/timer/cirrus,ep93xx-timer.yaml | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml > > diff --git a/Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml b/Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml > new file mode 100644 > index 000000000000..ce8b8a5cb90a > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/timer/cirrus,ep93xx-timer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus Logic EP93xx timers bindings > + > +maintainers: > + - Hartley Sweeten <hsweeten@visionengravers.com> > + - Alexander Sverdlin <alexander.sverdlin@gmail.com> > + > +properties: > + compatible: > + const: cirrus,ep9301-timer 1. Why only one compatible? 2. If this is kept, then filename matching compatible. Best regards, Krzysztof
On 28/04/2023 16:34, Nikita Shubin wrote: > On Tue, 2023-04-25 at 11:29 +0200, Krzysztof Kozlowski wrote: >> On 24/04/2023 14:34, Nikita Shubin wrote: >>> This adds device tree bindings for the Cirrus Logic EP93xx >>> timer block used in these SoCs. >>> >>> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> >>> --- >>> >>> Notes: >>> Arnd Bergmann: >>> - replaced ep93xx wildcard with ep9301 >>> >>> .../bindings/timer/cirrus,ep93xx-timer.yaml | 41 >>> +++++++++++++++++++ >>> 1 file changed, 41 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/timer/cirrus,ep93xx- >>> timer.yaml b/Documentation/devicetree/bindings/timer/cirrus,ep93xx- >>> timer.yaml >>> new file mode 100644 >>> index 000000000000..ce8b8a5cb90a >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/timer/cirrus,ep93xx- >>> timer.yaml >>> @@ -0,0 +1,41 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/timer/cirrus,ep93xx-timer.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Cirrus Logic EP93xx timers bindings >>> + >>> +maintainers: >>> + - Hartley Sweeten <hsweeten@visionengravers.com> >>> + - Alexander Sverdlin <alexander.sverdlin@gmail.com> >>> + >>> +properties: >>> + compatible: >>> + const: cirrus,ep9301-timer >> >> 1. Why only one compatible? >> 2. If this is kept, then filename matching compatible. > > I should rename the file to cirrus,ep9301-timer.yaml No, at least no yet. See point 1. Best regards, Krzysztof
On Tue, 2023-04-25 at 11:29 +0200, Krzysztof Kozlowski wrote: > On 24/04/2023 14:34, Nikita Shubin wrote: > > This adds device tree bindings for the Cirrus Logic EP93xx > > timer block used in these SoCs. > > > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > > --- > > > > Notes: > > Arnd Bergmann: > > - replaced ep93xx wildcard with ep9301 > > > > .../bindings/timer/cirrus,ep93xx-timer.yaml | 41 > > +++++++++++++++++++ > > 1 file changed, 41 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml > > > > diff --git a/Documentation/devicetree/bindings/timer/cirrus,ep93xx- > > timer.yaml b/Documentation/devicetree/bindings/timer/cirrus,ep93xx- > > timer.yaml > > new file mode 100644 > > index 000000000000..ce8b8a5cb90a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/timer/cirrus,ep93xx- > > timer.yaml > > @@ -0,0 +1,41 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/timer/cirrus,ep93xx-timer.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Cirrus Logic EP93xx timers bindings > > + > > +maintainers: > > + - Hartley Sweeten <hsweeten@visionengravers.com> > > + - Alexander Sverdlin <alexander.sverdlin@gmail.com> > > + > > +properties: > > + compatible: > > + const: cirrus,ep9301-timer > > 1. Why only one compatible? > 2. If this is kept, then filename matching compatible. I should rename the file to cirrus,ep9301-timer.yaml > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml b/Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml new file mode 100644 index 000000000000..ce8b8a5cb90a --- /dev/null +++ b/Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml @@ -0,0 +1,41 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/timer/cirrus,ep93xx-timer.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cirrus Logic EP93xx timers bindings + +maintainers: + - Hartley Sweeten <hsweeten@visionengravers.com> + - Alexander Sverdlin <alexander.sverdlin@gmail.com> + +properties: + compatible: + const: cirrus,ep9301-timer + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + resets: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + timer@80810000 { + compatible = "cirrus,ep9301-timer"; + reg = <0x80810000 0x100>; + interrupt-parent = <&vic1>; + interrupts = <19>; + }; +...
This adds device tree bindings for the Cirrus Logic EP93xx timer block used in these SoCs. Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> --- Notes: Arnd Bergmann: - replaced ep93xx wildcard with ep9301 .../bindings/timer/cirrus,ep93xx-timer.yaml | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml