| Message ID | 20230413101134.10627-1-shubhrajyoti.datta@amd.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v2] dt-bindings: clock: versal: Add versal-net compatible string | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 13/04/2023 12:11, Shubhrajyoti Datta wrote: > From: Jay Buddhabhatti <jay.buddhabhatti@xilinx.com> > > Add dt-binding documentation for Versal NET platforms. > > Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@xilinx.com> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com> > --- Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. First version was sent correctly, so why you decided here to do it differently? Anyway, you did not implement comments we asked you. There is no way this binding and your DTS works. There is no way you tested it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml index 4bbf96484b56..0029d94c4e1e 100644 --- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml +++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml @@ -20,7 +20,9 @@ select: false properties: compatible: - const: xlnx,versal-clk + enum: + - xlnx,versal-clk + - xlnx,versal-net-clk "#clock-cells": const: 1