| Message ID | 20230203-dt-bindings-network-class-v2-2-499686795073@jannau.net |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: net: Add network-class.yaml schema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Sun, Feb 12, 2023 at 01:16:30PM +0100, Janne Grunau wrote: > The network-class schema specifies local-mac-address as used in the > bcm4329-fmac device nodes of Apple silicon devices > (arch/arm64/boot/dts/apple). > Fixes `make dtbs_check` for those devices. Maybe a more hierarchical approach would be better? Add a wireless-controller.yaml which includes ieee80211.yaml and network-class.yaml? It would then follow the structure of Ethernet controllers, bluetooth controllers, and can controllers. Andrew
diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml index fec1cc9b9a08..55b0a21acb96 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml @@ -116,11 +116,14 @@ properties: NVRAM. This would normally be filled in by the bootloader from platform configuration data. +allOf: + - $ref: /schemas/net/network-class.yaml# + required: - compatible - reg -additionalProperties: false +unevaluatedProperties: false examples: - |
The network-class schema specifies local-mac-address as used in the bcm4329-fmac device nodes of Apple silicon devices (arch/arm64/boot/dts/apple). Fixes `make dtbs_check` for those devices. Signed-off-by: Janne Grunau <j@jannau.net> --- .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)