| Message ID | 20230121140053.10242-1-stefan.wahren@i2se.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/2] dt-bindings: arm: fsl: Fix bindings for APF28Dev board | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 19 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 21/01/2023 15:00, Stefan Wahren wrote: > Adjust the compatibles for the APF28Dev board in order to fix the > dtbs_check warning: > > DTC_CHK arch/arm/boot/dts/imx28-apf28dev.dtb > /home/stefanw/torvalds/arch/arm/boot/dts/imx28-apf28dev.dtb: /: compatible: > oneOf' conditional failed, one must be fixed: > ['armadeus,imx28-apf28dev', 'armadeus,imx28-apf28', 'fsl,imx28'] is too long > ['armadeus,imx28-apf28dev', 'armadeus,imx28-apf28', 'fsl,imx28'] is too short > ... > > Fixes: 3d735471d066 ("dt-bindings: arm: Document Armadeus SoM and Dev boards devicetree binding") > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 3ba354578e8f..599e8fcec6bc 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -88,12 +88,18 @@ properties: > items: > - enum: > - armadeus,imx28-apf28 # APF28 SoM Not related to your patch, but this looks odd. This is SoM, so even if it was made a DTS, it cannot be standalone board. The DTS or the compatible or both are misleading/incorrect. For the patch: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > - - armadeus,imx28-apf28dev # APF28 SoM on APF28Dev board > - fsl,imx28-evk > - i2se,duckbill > - i2se,duckbill-2 > - technologic,imx28-ts4600 > - const: fsl,imx28 Best regards, Krzysztof
On Sat, Jan 21, 2023 at 03:00:52PM +0100, Stefan Wahren wrote: > Adjust the compatibles for the APF28Dev board in order to fix the > dtbs_check warning: > > DTC_CHK arch/arm/boot/dts/imx28-apf28dev.dtb > /home/stefanw/torvalds/arch/arm/boot/dts/imx28-apf28dev.dtb: /: compatible: > oneOf' conditional failed, one must be fixed: > ['armadeus,imx28-apf28dev', 'armadeus,imx28-apf28', 'fsl,imx28'] is too long > ['armadeus,imx28-apf28dev', 'armadeus,imx28-apf28', 'fsl,imx28'] is too short > ... > > Fixes: 3d735471d066 ("dt-bindings: arm: Document Armadeus SoM and Dev boards devicetree binding") > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Applied both, thanks!
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 3ba354578e8f..599e8fcec6bc 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -88,12 +88,18 @@ properties: items: - enum: - armadeus,imx28-apf28 # APF28 SoM - - armadeus,imx28-apf28dev # APF28 SoM on APF28Dev board - fsl,imx28-evk - i2se,duckbill - i2se,duckbill-2 - technologic,imx28-ts4600 - const: fsl,imx28 + + - description: i.MX28 Armadeus Systems APF28Dev Board + items: + - const: armadeus,imx28-apf28dev + - const: armadeus,imx28-apf28 + - const: fsl,imx28 + - description: i.MX28 Duckbill 2 based Boards items: - enum:
Adjust the compatibles for the APF28Dev board in order to fix the dtbs_check warning: DTC_CHK arch/arm/boot/dts/imx28-apf28dev.dtb /home/stefanw/torvalds/arch/arm/boot/dts/imx28-apf28dev.dtb: /: compatible: oneOf' conditional failed, one must be fixed: ['armadeus,imx28-apf28dev', 'armadeus,imx28-apf28', 'fsl,imx28'] is too long ['armadeus,imx28-apf28dev', 'armadeus,imx28-apf28', 'fsl,imx28'] is too short ... Fixes: 3d735471d066 ("dt-bindings: arm: Document Armadeus SoM and Dev boards devicetree binding") Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- Documentation/devicetree/bindings/arm/fsl.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)