| Message ID | 20230111114337.24782-3-quic_sibis@quicinc.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Fix XPU violation during modem metadata authentication | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On 11/01/2023 12:43, Sibi Sankar wrote: > The dynamic memory region used for metadata authentication would still > be a part of the kernel mapping and any access to this region by the > application processor after assigning it to the remote Q6 will result > in a XPU violation. This is fixed by using a no-map carveout instead. > Update the bindings to reflect the addition of the new modem metadata > carveout on MSM8996 (and similar) SoCs. > > Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml index 1aa5e5c7c2bd..c1ac6ca1e759 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml @@ -122,6 +122,7 @@ properties: items: - description: MBA reserved region - description: Modem reserved region + - description: Metadata reserved region firmware-name: $ref: /schemas/types.yaml#/definitions/string-array @@ -172,6 +173,20 @@ properties: additionalProperties: false deprecated: true + metadata: + type: object + description: + Metadata reserved region + + properties: + memory-region: true + + required: + - memory-region + + additionalProperties: false + deprecated: true + required: - compatible - reg @@ -313,6 +328,7 @@ allOf: - required: - mba - mpss + - metadata additionalProperties: false @@ -355,7 +371,7 @@ examples: <&rpmhpd SDM845_MSS>; power-domain-names = "cx", "mx", "mss"; - memory-region = <&mba_mem>, <&mpss_mem>; + memory-region = <&mba_mem>, <&mpss_mem>, <&mdata_mem>; resets = <&aoss_reset AOSS_CC_MSS_RESTART>, <&pdc_reset PDC_MODEM_SYNC_RESET>;
The dynamic memory region used for metadata authentication would still be a part of the kernel mapping and any access to this region by the application processor after assigning it to the remote Q6 will result in a XPU violation. This is fixed by using a no-map carveout instead. Update the bindings to reflect the addition of the new modem metadata carveout on MSM8996 (and similar) SoCs. Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> --- v3: * add blank lines and additionalProperties: false to mdata objects [Krzysztof] .../remoteproc/qcom,msm8996-mss-pil.yaml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)