| Message ID | 20221228140610.938686-1-w.egorov@phytec.de |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: rtc: Add rv3028 to rv3032.yaml dtschema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 64 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Your subject is a bit incorrect. You do not add rv3028 to rv3032.yaml. Also drop redundant "dtschema". Instead "Extend rv3028 bindings" On 28/12/2022 15:06, Wadim Egorov wrote: > Move RV3028 RTC bindings from trivial-rtc.yaml into microcrystal,rv3032.yaml. > RV3028 can have a trickle-resitor-ohms property. Make it known to dtschema. I don't understand what is here made known to dtschema, so maybe drop last sentence. > > Signed-off-by: Wadim Egorov <w.egorov@phytec.de> > --- > .../bindings/rtc/microcrystal,rv3028.yaml | 56 +++++++++++++++++++ > .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - > 2 files changed, 56 insertions(+), 2 deletions(-) > create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > new file mode 100644 > index 000000000000..4abe4756bc9b > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/microcrystal,rv3028.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip RV-3028 RTC > + > +allOf: > + - $ref: "rtc.yaml#" Drop quotes. > + > +maintainers: > + - Alexandre Belloni <alexandre.belloni@bootlin.com> This should not be maintainer of subsystem but maintainer of device (unless it is the same person?). > + > +properties: > + compatible: > + const: microcrystal,rv3028 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + start-year: true Drop, it's coming from rtc.yaml. > + > + trickle-resistor-ohms: > + enum: > + - 3000 > + - 5000 > + - 9000 > + - 15000 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false Instead: unevaluatedProperties: false Best regards, Krzysztof
Am 28.12.22 um 15:15 schrieb Krzysztof Kozlowski: > Your subject is a bit incorrect. You do not add rv3028 to rv3032.yaml. > Also drop redundant "dtschema". Instead "Extend rv3028 bindings" > > > On 28/12/2022 15:06, Wadim Egorov wrote: >> Move RV3028 RTC bindings from trivial-rtc.yaml into microcrystal,rv3032.yaml. >> RV3028 can have a trickle-resitor-ohms property. Make it known to dtschema. > I don't understand what is here made known to dtschema, so maybe drop > last sentence. > >> Signed-off-by: Wadim Egorov <w.egorov@phytec.de> >> --- >> .../bindings/rtc/microcrystal,rv3028.yaml | 56 +++++++++++++++++++ >> .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - >> 2 files changed, 56 insertions(+), 2 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml >> >> diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml >> new file mode 100644 >> index 000000000000..4abe4756bc9b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml >> @@ -0,0 +1,56 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/rtc/microcrystal,rv3028.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Microchip RV-3028 RTC >> + >> +allOf: >> + - $ref: "rtc.yaml#" > Drop quotes. > >> + >> +maintainers: >> + - Alexandre Belloni <alexandre.belloni@bootlin.com> > This should not be maintainer of subsystem but maintainer of device > (unless it is the same person?). > Hi Krzysztof, who would be the maintainer for this RTC? I am not able to find a maintainer. Can I keep Alexandre Belloni as the maintainer since there seem to be no maintainer for the RV3028 RTC. Regards, Wadim
On 30/12/2022 12:09, Wadim Egorov wrote: >>> + >>> +maintainers: >>> + - Alexandre Belloni <alexandre.belloni@bootlin.com> >> This should not be maintainer of subsystem but maintainer of device >> (unless it is the same person?). >> > Hi Krzysztof, > > who would be the maintainer for this RTC? > I am not able to find a maintainer. > > Can I keep Alexandre Belloni as the maintainer since there seem to be no > maintainer for the RV3028 RTC. I guess it is fine. Alexandre contributed a lot to the driver, so actually he might know it. Best regards, Krzysztof
On 30/12/2022 11:09:32+0000, Wadim Egorov wrote: > Am 28.12.22 um 15:15 schrieb Krzysztof Kozlowski: > > Your subject is a bit incorrect. You do not add rv3028 to rv3032.yaml. > > Also drop redundant "dtschema". Instead "Extend rv3028 bindings" > > > > > > On 28/12/2022 15:06, Wadim Egorov wrote: > >> Move RV3028 RTC bindings from trivial-rtc.yaml into microcrystal,rv3032.yaml. > >> RV3028 can have a trickle-resitor-ohms property. Make it known to dtschema. > > I don't understand what is here made known to dtschema, so maybe drop > > last sentence. > > > >> Signed-off-by: Wadim Egorov <w.egorov@phytec.de> > >> --- > >> .../bindings/rtc/microcrystal,rv3028.yaml | 56 +++++++++++++++++++ > >> .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - > >> 2 files changed, 56 insertions(+), 2 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > >> new file mode 100644 > >> index 000000000000..4abe4756bc9b > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > >> @@ -0,0 +1,56 @@ > >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/rtc/microcrystal,rv3028.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Microchip RV-3028 RTC > >> + > >> +allOf: > >> + - $ref: "rtc.yaml#" > > Drop quotes. > > > >> + > >> +maintainers: > >> + - Alexandre Belloni <alexandre.belloni@bootlin.com> > > This should not be maintainer of subsystem but maintainer of device > > (unless it is the same person?). > > > Hi Krzysztof, > > who would be the maintainer for this RTC? > I am not able to find a maintainer. > I am the maintainer for this RTC driver > Can I keep Alexandre Belloni as the maintainer since there seem to be no > maintainer for the RV3028 RTC. > > Regards, > Wadim > >
diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml new file mode 100644 index 000000000000..4abe4756bc9b --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/microcrystal,rv3028.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Microchip RV-3028 RTC + +allOf: + - $ref: "rtc.yaml#" + +maintainers: + - Alexandre Belloni <alexandre.belloni@bootlin.com> + +properties: + compatible: + const: microcrystal,rv3028 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + start-year: true + + trickle-resistor-ohms: + enum: + - 3000 + - 5000 + - 9000 + - 15000 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + rtc@51 { + compatible = "microcrystal,rv3028"; + reg = <0x51>; + pinctrl-0 = <&rtc_nint_pins>; + interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>; + trickle-resistor-ohms = <3000>; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml index d9fc120c61cc..84cce1f0ca0c 100644 --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml @@ -48,8 +48,6 @@ properties: # Intersil ISL12022 Real-time Clock - isil,isl12022 # Real Time Clock Module with I2C-Bus - - microcrystal,rv3028 - # Real Time Clock Module with I2C-Bus - microcrystal,rv3029 # Real Time Clock - microcrystal,rv8523
Move RV3028 RTC bindings from trivial-rtc.yaml into microcrystal,rv3032.yaml. RV3028 can have a trickle-resitor-ohms property. Make it known to dtschema. Signed-off-by: Wadim Egorov <w.egorov@phytec.de> --- .../bindings/rtc/microcrystal,rv3028.yaml | 56 +++++++++++++++++++ .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - 2 files changed, 56 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml