| Message ID | 20221222084235.12235-2-shubhrajyoti.datta@amd.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | perf: Add xilinx APM support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 22/12/2022 09:42, Shubhrajyoti Datta wrote: > The LogiCORE IP AXI Performance Monitor core enables AXI system > performance measurement for multiple slots (AXI4/AXI3/ > AXI4-Stream/AXI4-Lite) activity. Add the devicetree binding for > xilinx APM. You did not implement what I asked for in the subject. > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com> > > > --- > > Changes in v2: > - Use boolean for the values xlnx,enable-profile , xlnx,enable-trace > and xlnx,enable-event-count > - Update the file name > - use generic node name pmu > > .../bindings/perf/xlnx,axi-perf-monitor.yaml | 133 ++++++++++++++++++ > 1 file changed, 133 insertions(+) > create mode 100644 Documentation/devicetree/bindings/perf/xlnx,axi-perf-monitor.yaml > > diff --git a/Documentation/devicetree/bindings/perf/xlnx,axi-perf-monitor.yaml b/Documentation/devicetree/bindings/perf/xlnx,axi-perf-monitor.yaml > new file mode 100644 > index 000000000000..72843504c946 > --- /dev/null > +++ b/Documentation/devicetree/bindings/perf/xlnx,axi-perf-monitor.yaml > @@ -0,0 +1,133 @@ > +# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/perf/xlnx,axi-perf-monitor.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx Axi Performance Monitor > + > +maintainers: > + - Shubhrajyoti Datta <shubhrajyoti.datta@amd.com> > + > +properties: > + compatible: > + const: xlnx,axi-perf-monitor > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + xlnx,profile: > + description: > + Has profile mode support. Event counting in profile mode consists of a > + fixed number of accumulators for each AXI4/AXI3/AXI4-Lite slot. All the > + events that can be counted are detected and given to the accumulator > + which calculates the aggregate value. There is no selection of events, > + and in this mode, event counting is done only on AXI4/AXI3/AXI4-Lite > + monitor slots. > + type: boolean > + > + xlnx,trace: > + description: > + Has trace mode support. In trace mode, the APM provides event logging in a > + reduced dynamic configuration. It captures the specified AXI events, > + external events and the time stamp difference between two successive > + events into the streaming FIFO. The selection of events to be captured > + is set through parameter configuration. Streaming agents are not > + supported in trace mode. > + type: boolean > + > + xlnx,num-monitor-slots: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Number of monitor slots. > + minimum: 1 > + maximum: 8 > + > + xlnx,event-count: > + description: > + Has event counting capability.. No need for double full stop. > + type: boolean > + > + xlnx,event-log: > + type: boolean > + description: > + Has event logging support. > + > + xlnx,have-sampled-metric-cnt: > + type: boolean > + description: > + Sampled metric counters enabled in APM. > + > + xlnx,metric-count-width: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - enum: [32, 64] Second time, the same problem. I wrote long time ago: "All of such comments apply everywhere." I'll stop review. Implement all the comments, not subset of them. Best regards, Krzysztof
[AMD Official Use Only - General] > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Thursday, December 22, 2022 3:22 PM > To: Datta, Shubhrajyoti <shubhrajyoti.datta@amd.com>; linux-arm- > kernel@lists.infradead.org > Cc: git (AMD-Xilinx) <git@amd.com>; devicetree@vger.kernel.org; > michal.simek@xilinx.com; krzysztof.kozlowski+dt@linaro.org; > robh+dt@kernel.org > Subject: Re: [PATCH v2 1/2] dt-bindings: Add the binding doc for xilinx APM > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > On 22/12/2022 09:42, Shubhrajyoti Datta wrote: > > The LogiCORE IP AXI Performance Monitor core enables AXI system > > performance measurement for multiple slots (AXI4/AXI3/ > > AXI4-Stream/AXI4-Lite) activity. Add the devicetree binding for xilinx > > APM. > > You did not implement what I asked for in the subject. > I missed out I will fix in next version.
On 23/12/2022 05:55, Datta, Shubhrajyoti wrote: >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: Thursday, December 22, 2022 3:22 PM >> To: Datta, Shubhrajyoti <shubhrajyoti.datta@amd.com>; linux-arm- >> kernel@lists.infradead.org >> Cc: git (AMD-Xilinx) <git@amd.com>; devicetree@vger.kernel.org; >> michal.simek@xilinx.com; krzysztof.kozlowski+dt@linaro.org; >> robh+dt@kernel.org >> Subject: Re: [PATCH v2 1/2] dt-bindings: Add the binding doc for xilinx APM >> >> Caution: This message originated from an External Source. Use proper >> caution when opening attachments, clicking links, or responding. >> >> >> On 22/12/2022 09:42, Shubhrajyoti Datta wrote: >>> The LogiCORE IP AXI Performance Monitor core enables AXI system >>> performance measurement for multiple slots (AXI4/AXI3/ >>> AXI4-Stream/AXI4-Lite) activity. Add the devicetree binding for xilinx >>> APM. >> >> You did not implement what I asked for in the subject. >> > I missed out I will fix in next version. Be sure you implemented all other comments. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/perf/xlnx,axi-perf-monitor.yaml b/Documentation/devicetree/bindings/perf/xlnx,axi-perf-monitor.yaml new file mode 100644 index 000000000000..72843504c946 --- /dev/null +++ b/Documentation/devicetree/bindings/perf/xlnx,axi-perf-monitor.yaml @@ -0,0 +1,133 @@ +# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/perf/xlnx,axi-perf-monitor.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xilinx Axi Performance Monitor + +maintainers: + - Shubhrajyoti Datta <shubhrajyoti.datta@amd.com> + +properties: + compatible: + const: xlnx,axi-perf-monitor + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + interrupts: + maxItems: 1 + + xlnx,profile: + description: + Has profile mode support. Event counting in profile mode consists of a + fixed number of accumulators for each AXI4/AXI3/AXI4-Lite slot. All the + events that can be counted are detected and given to the accumulator + which calculates the aggregate value. There is no selection of events, + and in this mode, event counting is done only on AXI4/AXI3/AXI4-Lite + monitor slots. + type: boolean + + xlnx,trace: + description: + Has trace mode support. In trace mode, the APM provides event logging in a + reduced dynamic configuration. It captures the specified AXI events, + external events and the time stamp difference between two successive + events into the streaming FIFO. The selection of events to be captured + is set through parameter configuration. Streaming agents are not + supported in trace mode. + type: boolean + + xlnx,num-monitor-slots: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Number of monitor slots. + minimum: 1 + maximum: 8 + + xlnx,event-count: + description: + Has event counting capability.. + type: boolean + + xlnx,event-log: + type: boolean + description: + Has event logging support. + + xlnx,have-sampled-metric-cnt: + type: boolean + description: + Sampled metric counters enabled in APM. + + xlnx,metric-count-width: + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [32, 64] + description: + Metric Counter width. + + xlnx,metric-count-scale: + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [1, 2, 4, 8] + description: + Metric Counter scale factor. + + xlnx,num-of-counters: + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + description: + Number of counters in APM. + + xlnx,metrics-sample-count-width: + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [32, 64] + description: + Sampled metric counter width. + + xlnx,global-count-width: + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [32, 64] + description: + Global Clock counter width. + + xlnx,id-filter-32bit: + description: APM is in 32-bit mode. + type: boolean + +required: + - compatible + - reg + - clocks + - interrupts + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + + pmu@44a00000 { + compatible = "xlnx,axi-perf-monitor"; + interrupt-parent = <&axi_intc_1>; + interrupts = <GIC_SPI 123 IRQ_TYPE_EDGE_RISING>; + reg = <0x44a00000 0x1000>; + clocks = <&clkc 15>; + xlnx,num-monitor-slots = <4>; + xlnx,event-count; + xlnx,event-log; + xlnx,have-sampled-metric-cnt; + xlnx,num-of-counters = <8>; + xlnx,metric-count-width = <32>; + xlnx,metrics-sample-count-width = <32>; + xlnx,global-count-width = <32>; + xlnx,metric-count-scale = <1>; + xlnx,id-filter-32bit; + };
The LogiCORE IP AXI Performance Monitor core enables AXI system performance measurement for multiple slots (AXI4/AXI3/ AXI4-Stream/AXI4-Lite) activity. Add the devicetree binding for xilinx APM. Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com> --- Changes in v2: - Use boolean for the values xlnx,enable-profile , xlnx,enable-trace and xlnx,enable-event-count - Update the file name - use generic node name pmu .../bindings/perf/xlnx,axi-perf-monitor.yaml | 133 ++++++++++++++++++ 1 file changed, 133 insertions(+) create mode 100644 Documentation/devicetree/bindings/perf/xlnx,axi-perf-monitor.yaml