| Message ID | 20220822130333.5353-2-shubhrajyoti.datta@amd.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | serial: pl011: Add xilinx uart | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 22/08/2022 16:03, Shubhrajyoti Datta wrote: > From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > > Some of the implementations support only 32-bit accesses. > Add a parameter reg-io-width for such platforms. > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > --- > v3: > patch addition > > Documentation/devicetree/bindings/serial/pl011.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/pl011.yaml b/Documentation/devicetree/bindings/serial/pl011.yaml > index d8aed84abcd3..c8a4cbb178fe 100644 > --- a/Documentation/devicetree/bindings/serial/pl011.yaml > +++ b/Documentation/devicetree/bindings/serial/pl011.yaml > @@ -94,6 +94,13 @@ properties: > resets: > maxItems: 1 > > + reg-io-width: > + description: | No need for | > + The size (in bytes) of the IO accesses that should be performed > + on the device. > + $ref: /schemas/types.yaml#/definitions/uint32 This is a standard type, so no need for $ref Best regards, Krzysztof
[AMD Official Use Only - General] > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, August 23, 2022 3:35 PM > To: Datta, Shubhrajyoti <shubhrajyoti.datta@amd.com>; linux- > serial@vger.kernel.org > Cc: git (AMD-Xilinx) <git@amd.com>; devicetree@vger.kernel.org; > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > gregkh@linuxfoundation.org; shubhrajyoti.datta@gmail.com > Subject: Re: [PATCH v3 1/2] dt-bindings: serial: pl011: Add a reg-io-width > parameter > > [CAUTION: External Email] > > On 22/08/2022 16:03, Shubhrajyoti Datta wrote: > > From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > > > > Some of the implementations support only 32-bit accesses. > > Add a parameter reg-io-width for such platforms. > > > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > > --- > > v3: > > patch addition > > > > Documentation/devicetree/bindings/serial/pl011.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/serial/pl011.yaml > b/Documentation/devicetree/bindings/serial/pl011.yaml > > index d8aed84abcd3..c8a4cbb178fe 100644 > > --- a/Documentation/devicetree/bindings/serial/pl011.yaml > > +++ b/Documentation/devicetree/bindings/serial/pl011.yaml > > @@ -94,6 +94,13 @@ properties: > > resets: > > maxItems: 1 > > > > + reg-io-width: > > + description: | > > No need for | Will fix > > > + The size (in bytes) of the IO accesses that should be performed > > + on the device. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > This is a standard type, so no need for $ref Will do. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/serial/pl011.yaml b/Documentation/devicetree/bindings/serial/pl011.yaml index d8aed84abcd3..c8a4cbb178fe 100644 --- a/Documentation/devicetree/bindings/serial/pl011.yaml +++ b/Documentation/devicetree/bindings/serial/pl011.yaml @@ -94,6 +94,13 @@ properties: resets: maxItems: 1 + reg-io-width: + description: | + The size (in bytes) of the IO accesses that should be performed + on the device. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [1, 4] + required: - compatible - reg