| Message ID | 20220530150548.1236307-6-m.felsch@pengutronix.de |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | TI SN65DSI83 Features | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi Marco, Am Montag, 30. Mai 2022, 17:05:48 CEST schrieb Marco Felsch: > The bridge device can now also be enabled/disabled by an external reset > controller. So the device now supports either enable/disable by simple > GPIO or by an Reset-Controller. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml index > 7306b9874dc3..eff8360c184e 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > @@ -35,6 +35,12 @@ properties: > vcc-supply: > description: A 1.8V power supply (see regulator/regulator.yaml). > > + resets: > + maxItems: 1 > + description: | > + Reset specifier for bridge_en pin. This is required only if the > brdige_en + pin is connected to a reset controller. > + > ports: > $ref: /schemas/graph.yaml#/properties/ports Maybe it should be added here, that 'resets' is an alternative to 'enable- gpios' as both are essentially controlling the same pin from the bridge. Best regards Alexander
Hi Alexander, On 22-05-31, Alexander Stein wrote: > Hi Marco, > > Am Montag, 30. Mai 2022, 17:05:48 CEST schrieb Marco Felsch: > > The bridge device can now also be enabled/disabled by an external reset > > controller. So the device now supports either enable/disable by simple > > GPIO or by an Reset-Controller. > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > --- > > .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml index > > 7306b9874dc3..eff8360c184e 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > @@ -35,6 +35,12 @@ properties: > > vcc-supply: > > description: A 1.8V power supply (see regulator/regulator.yaml). > > > > + resets: > > + maxItems: 1 > > + description: | > > + Reset specifier for bridge_en pin. This is required only if the > > brdige_en + pin is connected to a reset controller. > > + > > ports: > > $ref: /schemas/graph.yaml#/properties/ports > > Maybe it should be added here, that 'resets' is an alternative to 'enable- > gpios' as both are essentially controlling the same pin from the bridge. I mention the bridge_en pin two times :) But I could also add that this is an alternative to the enable-gpios. Maybe it even more clear than. Regards, Marco > > Best regards > Alexander > > >
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml index 7306b9874dc3..eff8360c184e 100644 --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml @@ -35,6 +35,12 @@ properties: vcc-supply: description: A 1.8V power supply (see regulator/regulator.yaml). + resets: + maxItems: 1 + description: | + Reset specifier for bridge_en pin. This is required only if the brdige_en + pin is connected to a reset controller. + ports: $ref: /schemas/graph.yaml#/properties/ports
The bridge device can now also be enabled/disabled by an external reset controller. So the device now supports either enable/disable by simple GPIO or by an Reset-Controller. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 6 ++++++ 1 file changed, 6 insertions(+)